Closed
Bug 594339
Opened 14 years ago
Closed 14 years ago
Turn aFromParser, mParserCreated, etc. from PRUint32 + #defines into an enum
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: Ms2ger)
Details
Attachments
(1 file)
97.72 KB,
patch
|
hsivonen
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Variables that indicate whether a node was script-created or parser-created (and how exactly parser-created) should use an enum instead of PRUint32 and these #defines: http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsContentCreatorFunctions.h#59
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → Ms2ger
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #483289 -
Flags: review?(hsivonen)
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 483289 [details] [diff] [review] Patch v1 r=hsivonen. I noticed that there were some clean-up bits that weren't strictly speaking fixing this bug, but all those clean-ups looked good to me. Thanks for fixing this! Since I'm not officially qualified to act as a reviewer here, I'm requesting sr.
Attachment #483289 -
Flags: superreview?(bzbarsky)
Attachment #483289 -
Flags: review?(hsivonen)
Attachment #483289 -
Flags: review+
Comment 3•14 years ago
|
||
Comment on attachment 483289 [details] [diff] [review] Patch v1 Looks fine.
Attachment #483289 -
Flags: superreview?(bzbarsky) → superreview+
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 483289 [details] [diff] [review] Patch v1 Requesting approval for 2.0. This is a low-risk patch that'll bitrot extremely quickly. If we don't land this soon, it'll bitrot. OTOH, landing it soon would be harmless.
Attachment #483289 -
Flags: approval2.0?
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 5•14 years ago
|
||
Landed with a=jonas as a dependency for bug 604924. http://hg.mozilla.org/mozilla-central/rev/6aad432efa02
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•14 years ago
|
Attachment #483289 -
Flags: approval2.0?
Reporter | ||
Comment 6•14 years ago
|
||
Doh. I meant bug 604660.
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•