594484 - disabled number box styling is broken

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

The text isn't greyed out, and the cursor is wrong too.

<textbox type="number" disabled="true" value="20"/>

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch?

This seems to fix it, but I don't really know if there's a better way to do this, or whether this is complete given the other styling in that file.

Comment 2

[Neil Deakin]

Why does this only affect Mac?

Comment 3

[Dão Gottwald [:dao]]

Is this a regression?

Comment 4

[Markus Stange [:mstange]]

I think you just need to remove the color and cursor properties from the .numberbox-input-box rule in numberbox.css. The correct color is already set on the textbox and just needs to be inherited down properly. For the non-disabled case, cursor:text is set by forms.css on the html:input and doesn't need to be set on the .numberbox-input-box.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 473149 [details] [diff] [review]
patch?

I have no idea if this ever worked, or why it only affects Mac. Sounds like Markus' suggestion is better, though.

Comment 6

[Markus Stange [:mstange]]

Attachment: v1

Can you test this on Linux?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Works for me on Linux - cursor is "text" when enabled, normal when disabled.

Comment 8

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/8130457aed61