594737 - select list not greyed out when disabled, size and multiple attributes all set

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[beldaz.jalfrezi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 ( .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 ( .NET CLR 3.5.30729)

While creating an HTML form I found difficulty disabling portions using the "disabled" attribute. Further investigation showed that this attribute was not respected in select lists in conjunction with the "multiple" and "size" attributes.

Reproducible: Always

Steps to Reproduce:
1. Create a form containing a select list
2. Add the attribute disabled="disabled"
3. Add the attribute multiple="multiple"
4. Add the attribute size="4"
5. Try different combinations of the above attributes

Actual Results:  
The select box is disabled when the disabled attibute is set along with a combination of the other attributes, but when all attributes are set the box is no longer disabled.

Expected Results:  
Select box should be disabled in all cases where the diabled attibute is set. (Works correctly in IE8)

Comment 1

[beldaz.jalfrezi]

Attachment: Simple HTML test case

This test case contains a form with three select lists holding the same options. All three lists have the "disabled" attribute set, and so should be disabled in the browser. In the reported bug, the first list (with "multiple" and "size" attributes also set) is not disabled.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er... it's disabled just fine.  It just doesn't get the grayed-out coloring, right?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 4

[beldaz.jalfrezi]

(In reply to comment #2)
> Er... it's disabled just fine.  It just doesn't get the grayed-out coloring,
> right?

You're quite right: it's disabled but not grayed out accordingly. Sorry for not diagnosing the bug correctly.

Comment 5

[beldaz.jalfrezi]

Updated summary to avoid misleading reader

Comment 6

[Boris Zbarsky [:bzbarsky]]

Thanks for double-checking that!

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 473659 [details] [diff] [review]
Fix

r=dbaron

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/4817c29dc507