595094 - Implement Desktop Notifications in Fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

+++ This bug was initially created as a clone of Bug #573588 +++

I reviewed the WebNotification spec:
   http://dev.w3.org/2006/webapi/WebNotifications/publish/

and the google spec:
   http://code.google.com/p/gears/wiki/NotificationAPI


and I think both are a bit more complex than we need.


My current thinking is title, description, uri to image, and a callback for if/when the user clicks on the notification:

navigator.notification.notify("title",
                              "description",
			      "uri to image",
			      function() {})


-----

I cloned a firefox specific bug.  This is for Fennec specific work for Desktop Notifications

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

the image is just a copy of the geo prompt.

also, somewhat related - i do not see the icon for the prompt in the build even without my changes.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 474343 [details] [diff] [review]
patch v.1

>diff --git a/components/ContentPermissionPrompt.js b/components/ContentPermissionPrompt.js

>+  prompt: function(request) {
>+    Services.console.logStringMessage("nsIContentPermissionPrompt prompt() called for request type " + request.type);

Remove the debug output
						     [request.uri.host], 1);
>+    let newBar = notificationBox.appendNotification(message,
>+						    request.type,
>+						    "chrome://browser/skin/images/" + request.type + "-16.png",

Notifications in Fennec do not display images, so just send "". The images take up too much valuable space.

NOTE: There are TABs in this file :(

>diff --git a/themes/core/images/desktop-notification-16.png b/themes/core/images/desktop-notification-16.png
>diff --git a/themes/core/images/geo-16.png b/themes/core/images/geolocation-16.png
>rename from themes/core/images/geo-16.png
>rename to themes/core/images/geolocation-16.png

Don't add any images

>diff --git a/themes/core/jar.mn b/themes/core/jar.mn

>-  skin/images/geo-16.png                    (images/geo-16.png)
>+  skin/images/geolocation-16.png            (images/geolocation-16.png)
>+  skin/images/desktop-notification-16.png   (images/desktop-notification-16.png)

Remove

r+ with the images and TABs removed

Comment 4

[Doug Turner (:dougt)]

thanks.

http://hg.mozilla.org/mobile-browser/rev/2cf977860f46

E10s still need some support (bug 595456)