Closed
Bug 595304
Opened 14 years ago
Closed 14 years ago
Rename "TabPin" to "TabPinned" and "TabUnpin" to "TabUnpinned"
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
|
3.72 KB,
patch
|
Details | Diff | Splinter Review |
See bug 593872 comment 9.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #474169 -
Flags: review?(dao)
|
||
Updated•14 years ago
|
Attachment #474169 -
Flags: review?(dao) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #474169 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 474169 [details] [diff] [review] Patch (v1) There are comments in the test that could use updating too...
Attachment #474169 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #474169 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c4c9b356c106
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
|
||
Comment 5•14 years ago
|
||
Documented the pinned attribute for tabs, which was not yet documented: https://developer.mozilla.org/en/XUL/Attribute/pinned That's linked to from: https://developer.mozilla.org/en/XUL/tab Documented the pinTab and unpinTab methods on tabbrowser, which also was not yet documented: https://developer.mozilla.org/en/XUL/Method/pinTab https://developer.mozilla.org/en/XUL/Method/unpinTab Those are linked from: https://developer.mozilla.org/en/XUL/tabbrowser And the TabPinned and TabUnpinned events are now documented as well (as well as any of our events are documented, anyway): https://developer.mozilla.org/en/Code_snippets/Tabbed_browser#Notification_when_a_tab_is_pinned_or_unpinned Firefox 4 for developers is also updated. Whew!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•