595326 - Create developer profile status bar

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Mockup: http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_06_Profile.png

This is the last section in the mockup.  It should use similar styles to the contributions status bar. 

Backend:
- The mockup says it too, but:  If you have contributions enabled, you have to have a dev profile enabled.  If you disable the dev profile, it will disable contributions too.  These fields exist in the db and the logic is in remora.

Frontend:
- How YOU doin'?

Comment 1

[Jeff Balogh (:jbalogh)]

Why are we getting hidden developer profiles?  That's new code and bugs and invalid states that we don't need.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> Why are we getting hidden developer profiles?  That's new code and bugs and
> invalid states that we don't need.

I talked to chowse and we agreed we could do this better.  He'll update the mockup, but we're going for just having the status bar at the top that says "Your developer profile is currently <b>enabled</b> and <b>required</b> for contributions." and has a "Clear both" button.  If the button is clicked it...clears both, and disables contributions.

If you don't have a dev profile, we can omit the status bar.

Comment 3

[Chris Howse [:chowse]]

I've updated the Profile and Contributions mock-ups w/ new status bars. This should hopefully make the new behavior clearer.

http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_04_Payments.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_06_Profile.png

Comment 4

[Wil Clouser [:clouserw]]

I'm giving this to jbalogh since it's pretty much the same code as the contributions one.  Please work with cvan though, since he's doing the dev pages.

Comment 5

[Jeff Balogh (:jbalogh)]

The status bar on profiles feels weird. I'm fine with the text[1] but "Remove both" doesn't fit.  It's supposed to be like "Disable contributions" on the payment page, but it sounds like it's going to delete all your paypal data when it clears the profile.

We don't offer "clear these textareas" on other pages, and it seems like an odd thing to do. Can we just go with the notification text and then make sure the form isn't cleared if contributions are enabled?


[1]: "Your developer profile is currently <b>enabled</b> and <b>required</b> for
contributions."

Comment 6

[Justin Scott [:fligtar]]

I yield to chowse on this interaction.

Comment 7

[Chris Howse [:chowse]]

(In reply to comment #5)
> The status bar on profiles feels weird. I'm fine with the text[1] but "Remove
> both" doesn't fit.  It's supposed to be like "Disable contributions" on the
> payment page, but it sounds like it's going to delete all your paypal data when
> it clears the profile.

It will. According to Wil, we won't support enabling/disabling the developer profile or contributions, only blanking them out. This was changed in the Contributions mocks as well.

> We don't offer "clear these textareas" on other pages, and it seems like an odd
> thing to do.

I agree, but I feel there needs to be an explicit way to turn off your developer profile and (especially) contributions. Ideally, this would be a reversible option (the enable/disable option), but I was informed that this wouldn't be supported for this version. The 'clear all fields' option was my compromise; otherwise, there is no clear way to disable your profile or contributions.

> Can we just go with the notification text and then make sure the
> form isn't cleared if contributions are enabled?

And then what action would the user take? Go to the Contributions page, remove/disable it there, then switch back to the Profile page and remove/disable that? These are the steps that 'Remove Both' encapsulates.

Comment 8

[Jeff Balogh (:jbalogh)]

(In reply to comment #7)
> It will. According to Wil, we won't support enabling/disabling the developer
> profile or contributions, only blanking them out. This was changed in the
> Contributions mocks as well.

We support disabling contributions already.

Comment 9

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/ce34986

I'm deleting [qa-] since qa always needs more to do, and this is a nice small piece to verify.

Comment 10

[krupa raj[:krupa]]

Verified the following status messages:

* Your developer profile is currently public and required for contributions.- Remove both
* You are currently requesting contributions from users- Disable contributions
* Your developer profile is currently public.- Remove Profile

checked that developer profile is required to ask for contributions.