595390 - Don't use bold button labels

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Michael Monreal [:micmon]]

The update manager displays some buttons with bold labels which is something I have not seen in any other Linux application.

Comment 1

[Michael Monreal [:micmon]]

Attachment: Remove bold rules

Comment 2

[Robert Strong (they/them - no direct email)]

I had this same discussion with the Firefox UX team a while ago though it was about this not being normal for all platforms. I'll change the ui-review request to see if bold button text is still wanted.

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 474261 [details] [diff] [review]
Remove bold rules

removing review request until after ur-review.

Comment 4

[Robert Strong (they/them - no direct email)]

Changing summary with the following rationale. If user experience approves the ui-review the bold label should be removed at the very least on Windows since the default button is natively styled to draw attention to it on Windows. This isn't so clear on Mac OS X since our custom styling doesn't have native styling or custom styling to draw attention to it so it might be valuable to leave the text bold on Mac OS X.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 474261 [details] [diff] [review]
Remove bold rules

Alex, this is in regards to the bold button text in the update UI that we've discussed previously. If it is decided to remove the bold text I would want it also removed at the very least on Windows for the reasons stated in comment #4.

Comment 6

[Michael Monreal [:micmon]]

Attachment: Screenshot of Linux apps

As I originally filed this bug especially for Linux, here's a collection of screenshots showing the last pages of various wizard dialogs of Evolution (GNOME's official PIM app), Empathy (GNOME's official IM app) and OpenOffice Impress. The same results can be seen in Gimp and Ekiga for example.

Comment 7

[Robert Strong (they/them - no direct email)]

Yep, the same is true for the other platforms and if we are going to change one they should be changed on all for the exact same reason you'd like it changed on Linux.

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 474261 [details] [diff] [review]
Remove bold rules

Awesome! Please remove the bold from all the themes... gnomestripe, pinstripe, and winstripe and I'll r+ it.

Comment 9

[Michael Monreal [:micmon]]

Attachment: Remove bold rules on Win+Mac+Lin

Comment 10

[Robert Strong (they/them - no direct email)]

I'll try to get approval and land this on Monday

Comment 11

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/5ff46fc54245

Thanks for the patches!