595615 - js: hidden symbol `js::ShapeHasher::match(js::Shape*, js::Shape const*)' isn't defined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[ojab]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b6pre) Gecko/20100912 Firefox/4.0b6pre
Build Identifier: 

Compilation fails after -r53651:3feb012b18a3 with

c++ -o js  -fno-rtti -fno-exceptions -Wall -Wpointer-arith …
/usr/lib/gcc/x86_64-unknown-linux-gnu/4.5.2/../../../../x86_64-unknown-linux-gnu/bin/ld: js: hidden symbol `js::ShapeHasher::match(js::Shape*, js::Shape const*)' isn't defined
/usr/lib/gcc/x86_64-unknown-linux-gnu/4.5.2/../../../../x86_64-unknown-linux-gnu/bin/ld: final link failed: Nonrepresentable section on output
collect2: ld returned 1 exit status
make[5]: *** [js] Error 1
make[5]: Leaving directory `/home/ojab/src/firefox/js/src/shell'


Reproducible: Always




GNU ld (GNU Binutils) 2.20.51.20100620
gcc version 4.5.2 20100903 (prerelease) (GCC)

Comment 1

[Igor Bukanov]

This affects only DEBUG builds due to the use of inline keyword in jspropertytree.cpp on: 

inline HashNumber
ShapeHasher::hash(const Lookup l)

Bug 593256 has added a DEBUG-only reference to ShapeHasher::hash from JSObject::checkShapeConsistency(). As a workaround in the local tree I just dropped the inline keywords from ShapeHasher::hash and ShapeHasher::match. A better solution I guess would be to move the inlines into some header.

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 474533 [details] [diff] [review]
fix

r=dbaron.

It would probably be good to declare the inline methods as inline where they're declared in addition to where they're defined, though.  I think that way you might be more likely to get errors/warnings about this.

Comment 4

[Brendan Eich [:brendan]]

Attachment: what I'm landing

Also fix a JS_CHECK_SHAPE_THROTTLE=non-zero plus DEBUG-only failure to check consistency in edge case. This doesn't affect debug or release builds; to get the checking you have to build DEBUG and set that JS_CHECK_SHAPE_THROTTLE envar.

/be

Comment 5

[Brendan Eich [:brendan]]

Oops, missed David's suggestion -- I'll add inline to the static member decls before landing.

/be

Comment 6

[Brendan Eich [:brendan]]

Attachment: really gonna land this, I swear

I love how Mac GCC failed to catch the problem reported in this bug...

/be

Comment 7

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/60bbf40c518f
http://hg.mozilla.org/mozilla-central/rev/fc4dc7ff4e9a

/be