595641 - Double right-clicking on the title bar randomly performs actions (focusing areas, opening the bookmark sidebar, etc.)

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[u88484]

Double right-clicking on the title bar randomly performs actions (focusing areas, opening the bookmark sidebar, etc.)  No errors in the error console.

This was confirmed by two other users on mozillazine.

Comment 1

[u88484]

Adding dataloss because I just had my current page change to about:home

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

What OS? Aero on/off? Accelerated Layers on/off?

Comment 3

[c221752]

(In reply to comment #2)
> What OS? Aero on/off? Accelerated Layers on/off?

Windows XP Pro. Accelerated Layers on.

Comment 4

[c221752]

(In reply to comment #3)
> (In reply to comment #2)
> > What OS? Aero on/off? Accelerated Layers on/off?
> 
> Windows XP Pro. Accelerated Layers on.

Just tried it with Accelerated Layers off, the bug is still there.

Comment 5

[Dave Buco]

Mozilla/5.0 (Windows NT 6.0; WOW64; rv:2.0b5) Gecko/20100101 Firefox/4.0b5

With menu bar disabled - for me I get the following: double right clicking in various locations to the right of the orange Firefox button refreshes page, opens the sidebar, closes the sidebar, highlights text in the searchbar, opens home page in current tab.

Windows Vista, Service Pack 2, 64-bit

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Jimm, can you reproduce this and diagnose? Or Felipe?

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

that was a freaky bug!

WM_NCRBUTTONDBLCLK falls through WM_APPCOMMAND

Comment 8

[Nochum Sossonko [:Natch]]

This seems like it should get some test love...

Comment 9

[:Felipe Gomes (needinfo for replies!)]

(In reply to comment #8)
> This seems like it should get some test love...

This was a problem in the native event processing so a mochitest won't be able to cover it. Maybe we could include a litmus test. (although I don't think it's necessary as it'd be hard to regress this, and the bug is not 100% reproducible -- depends on the X/Y position of the click)

Comment 10

[Nochum Sossonko [:Natch]]

(In reply to comment #9)
> This was a problem in the native event processing so a mochitest won't be able
> to cover it.

That kinda sucks. Is there no way to send a native mouse event to the titlebar and synthesize the right-click?

> Maybe we could include a litmus test. (although I don't think it's
> necessary as it'd be hard to regress this, and the bug is not 100% reproducible
> -- depends on the X/Y position of the click)

It's these type of hard to notice, corner cases that need to be auto-guarded IMHO.

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Fixed by changeset http://hg.mozilla.org/mozilla-central/rev/0eb96c685fed