Closed Bug 595682 Opened 14 years ago Closed 14 years ago

Always generate PNG images for charts

Categories

(Bugzilla :: Reporting/Charting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(1 file)

The current code in reports.cgi does this check:

    my $type = $testimg->can('gif') ? "gif" : "png";

IMO, there is no reason to generate GIF images anymore, and we should always produce PNG images instead.

Gerv, are you fine with this change?
Yep, no problem.

Gerv
Attached patch patch, v1Splinter Review
I also cleaned up the list of contributors a bit, to match what we do in all other files. Granting myself review as I can now clean up charts and series code without asking for review.
Assignee: charting → LpSolit
Status: NEW → ASSIGNED
Attachment #482826 - Flags: review+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified reports.cgi
Committed revision 7529.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: approval+
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 4.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: