596006 - Tweak disco pane copy and stuff

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Description

[Justin Scott [:fligtar]]

Bug for my tweaks patch to discovery pane.

Comment 1

[Justin Scott [:fligtar]]

http://github.com/fligtar/zamboni/commit/3a270c03f49d9984fdfcc2d59605353b06402bb7

1. The new collection id used (82266) is in production. It probably doesn't exist on preview and will cause problems. I can try to fake it after the db changes are done.

2. I think we need to add an href to the <base> with SITE_URL but I don't know how to do that, so please fix that after this patch.

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to comment #1)
> 2. I think we need to add an href to the <base> with SITE_URL but I don't know
> how to do that, so please fix that after this patch.

I think koberger is doing that.

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> (In reply to comment #1)
> > 2. I think we need to add an href to the <base> with SITE_URL but I don't know
> > how to do that, so please fix that after this patch.
> 
> I think koberger is doing that.
It's done, just needs to land.

Comment 4

[Justin Scott [:fligtar]]

the id of the test collection on preview is 82170 if someone wants to change its id to the one in the code so we don't get errors.

Comment 5

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/80bb299

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good on https://addons.mozilla.org/z/en-US/firefox/discovery/4.0b5pre/Darwin; fligtar, can you double-check, and also verify comment 4?  Thanks.