Closed Bug 596996 Opened 14 years ago Closed 14 years ago

-silent and -chrome command line flags are busted in Fennec

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Maemo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(fennec2.0b2+)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: aakashd, Assigned: mfinkle)

Details

Attachments

(1 file)

patch
1.37 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review 
Build Id:
Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre

Steps to Reproduce:
1. Go to the App Manager
2. Update to the latest nightly build (i'm using the trunk_multi repo)

Actual Results:
Once the installation is completed in the App manager, Fennec starts up with the app manager in the background.

Expected Results:
Fennec should not start up unless I told it to.
tracking-fennec: --- → ?
When did this start?
http://mxr.mozilla.org/mobile-browser/source/installer/debian/fennec.postinst.in#13
Assignee: nobody → mark.finkle
tracking-fennec: ? → 2.0b2+
We are not handling the -silent flag correctly. BrowserCLH.js has the code
Summary: Fennec starts up after installation on the N900 → -silent and -chrome command line flags are busted in Fennec
Attached patch patch — — Splinter Review 
Recent refactors to the commandline handling must have broken the -silent and -chrome cmdline flags.

This patch fixes them
Attachment #476316 - Flags: review?(mbrubeck)
Attachment #476316 - Flags: review?(mbrubeck) → review+
landing for beta 1, since this affects testing too
pushed:
http://hg.mozilla.org/mobile-browser/rev/462d5f00e827
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Still launches during the installing phase:

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100917 Firefox/4.0b7pre Fennec/2.0b1pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Naoki - What build did you test? This just landed today (9/17). Did you make a build?
I made a mistake; I missed the timing of the push.  setting back to resolved and will regress next build.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
verified FIXED on build:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100920 Namoroka/4.0b7pre Fennec/2.0b1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: