597246 - pymake bustage in js/src

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Somewhere between my build yesterday (http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7cf62a2a821e) and today, pymake was broken when building in js/src.

Starting with checks.cc, errors like the following appear:
c1xx : fatal error C1083: Cannot open source file: 'c:/mozbuild/mozilla-central/objdir-fx/js/src/checks.cc': No such file or directory

Comment 1

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/d28edafb9a84

But from reading it, that patch looks perfectly fine.

Comment 3

[David Mandelin [:dmandelin]]

Attachment: Workaround

This will allow pymake builds to go through pending fixes to pymake.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 476097 [details] [diff] [review]
Workaround

r=me if you add something like this before the "Two related functions" paragraph in v8-dtoa/README:

  All the imported files had their .cc extensions changed to .cpp, because the .cc extensions caused problems with pymake builds on Windows.

Comment 5

[Justin Wood (:Callek)]

Is this a case of VPATH additions not working and/or Multiple VPATHs? or something else?

Comment 6

[David Mandelin [:dmandelin]]

Attachment: Workaround updated per njn's comment

bsmedberg is debugging now, so I'm not landing this yet.

Comment 7

[Benjamin Smedberg]

Attachment: Better fix

This is the better fix. I will not have a chance to land this before I leave, and the tree isn't green, so somebody please land this for me!

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I'll check this in once the tree is green.

Comment 9

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/150d64f4e03e