Closed Bug 597448 Opened 14 years ago Closed 13 years ago

NJ needs tweak to work with new valgrind scheme

Categories

(Core Graveyard :: Nanojit, defect, P3)

Product:
Core Graveyard
Component:
Nanojit
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: treilly, Unassigned)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 file)

Don't define VALGRIND_DISCARD_TRANSLATIONS if its already defined
421 bytes, patch
edwsmith
: review+
Details | Diff | Splinter Review 
Trying to prepare the patient for landing valgrind
Attachment #476292 - Flags: review?(edwsmith)
Blocks: 509020
Attachment #476292 - Attachment is patch: true
Attachment #476292 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 476292 [details] [diff] [review]
Don't define VALGRIND_DISCARD_TRANSLATIONS if its already defined

Looks fine.  Note that this duplicates part of the patch for bug 578673, and also duplicates Julian's version of the same tweak, in the first attachment of 509020. 

R+ if you turn it into the one-liner like in Julian's patch.
Attachment #476292 - Flags: review?(edwsmith) → review+
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.2.x-Spicy
http://hg.mozilla.org/tamarin-redux/rev/49509a7cd831
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
adding more links, changing product field, leaving open until merged to TM.

NC: http://hg.mozilla.org/projects/nanojit-central/rev/aaa4e162e47e
Status: RESOLVED → REOPENED
Component: Virtual Machine → Nanojit
Product: Tamarin → Core
QA Contact: vm → nanojit
Resolution: FIXED → ---
Whiteboard: fixed-in-nanojit, fixed-in-tamarin
Target Milestone: flash10.2.x-Spicy → ---
merged happened earlier today (or yesterday) courtesy Bill
nevermind, TM == tracemonkey not tamarin, removing block on valgrind bug since its fixed in TR
No longer blocks: 509020
Assignee: treilly → nobody
http://hg.mozilla.org/tracemonkey/rev/a4981e82b048
Status: REOPENED → RESOLVED
Closed: 14 years ago → 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: