597455 - JM: Compile JSOP_FOR*

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

iterNext() really wants the iterator to be at sp[-1], rather than fiddle with that and its slow paths, some ops just rearrange the stack.

Comment 3

[Brendan Eich [:brendan]]

I summon Andreas.

/be

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Fiddling with the stack here shouldn't affect perf, it's just internal bookkeeping. There's a chance when taking the slow path, there may be more memory shuffling, but not enough to cause concern.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/tracemonkey/rev/11b020daa97e

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/11b020daa97e