597578 - add CommonJS assert module

Status: RESOLVED WONTFIX

(Testing Graveyard :: Mozmill, defect)

Description

[Heather Arthur [:harth]]

We should add the standard CommonJS assert module to Mozmill, putting it in the scope so test authors can import with:

var assert = require("assert");

assert.ok(true, "this should be true");

The specification lives here http://wiki.commonjs.org/wiki/Unit_Testing/1.0#Assert

The most up-to date implementation lives in node.js http://github.com/ry/node/blob/master/lib/assert.js, we will probably steal from one of the current implementations

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Those will replace the JUM module's functions or our controller assert functions? I assume the first ones.

Comment 2

[Heather Arthur [:harth]]

Yeah, it could replace the JUM module. The assert module contains less assert variations than the JUM module, but is pretty flexible:

JUM.assertUndefined(property) == assert.strictEqual(property, undefined)
JUM.assertNotNull(property) == assert.notStrictEqual(property, null)

JUM:
["assert", "assertTrue", "assertFalse", "assertEquals", "assertNotEquals",
 "assertNull", "assertNotNull", "assertUndefined", "assertNotUndefined",
 "assertNaN", "assertNotNaN", "fail", "pass"]
 
CommonJS assert:
["ok", "equal", "notEqual", "deepEqual", "notDeepEqual", "strictEqual", "notStrictEqual", "throws"]

Comment 3

[cmtalbert]

I believe Heather's already working on this.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm also working on a solution for our shared modules right now. Lets sit together for a better planning. My current work happens on bug 634225.

Comment 5

[Heather Arthur [:harth]]

doing a CommonJS-based, but customized assert module in bug 637880

Comment 6

[Mark Hammond [:markh] [:mhammond]]

Stumbled on this bug - FTR, the CommonJS assert module did land in bug 873126.