Closed
Bug 598227
Opened 14 years ago
Closed 14 years ago
Add support NPP_ImageDraw API for Maemo5
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(fennec2.0+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0+ | --- |
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(2 files, 2 obsolete files)
9.59 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
7.29 KB,
patch
|
Details | Diff | Splinter Review |
I think we should add possibility to render plugins on maemo using image rendering API...
Assignee | ||
Updated•14 years ago
|
OS: Linux → Maemo
Hardware: x86 → ARM
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #477018 -
Flags: feedback?(doug.turner)
Assignee | ||
Comment 2•14 years ago
|
||
Assignee: nobody → romaxa
Attachment #477018 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #477053 -
Flags: review?(doug.turner)
Attachment #477018 -
Flags: feedback?(doug.turner)
Comment 3•14 years ago
|
||
Comment on attachment 477053 [details] [diff] [review] Fixed style and Windowlessloacal init > #endif >+#if (MOZ_PLATFORM_MAEMO == 5) >+ , mSupportsImageRendering(PR_FALSE) >+#endif mSupportsImageRendering --> mMaemoImageRendering Would initing this here be better then when we test for WindowlessLocal? Also, maybe we should just make this a static? >+#if (MOZ_PLATFORM_MAEMO == 5) >+ // Plugin is about to be rendered, >+ // on maemo 5 we should send Visibility event to activate plugin On Maemo 5, we must send the Visibility event to activate the plugin >+#if (MOZ_PLATFORM_MAEMO == 5) >+ if (mSupportsImageRendering) { >+ // No helper surface needed, when mSupportsImageRendering and maemo >+ // we can do direct rendering into image memory after var rename, change this comment. >+#if (MOZ_PLATFORM_MAEMO == 5) >+ // On maemo5 we do support Image rendering NPAPI >+ if (aSurface->GetType() == gfxASurface::SurfaceTypeImage && >+ mSupportsImageRendering) { test for mMaemoImageRendering first to avoid the call on aSurface. > #ifdef MOZ_X11 > if (mIsTransparent && mFlash10Quirks) { > // Work around a bug in Flash up to 10.1 d51 at least, where expose event > // top left coordinates within the plugin-rect and not at the drawable > // origin are misinterpreted. (We can move the top left coordinate > // provided it is within the clipRect.), see bug 574583 > plPaintRect.SetRect(0, 0, aRect.XMost(), aRect.YMost()); > } >- if (renderSurface->GetType() != gfxASurface::SurfaceTypeXlib) { >+ if (renderSurface->GetType() != gfxASurface::SurfaceTypeXlib >+ && mHelperSurface) { > // On X11 we can paint to non Xlib surface only with HelperSurface > renderSurface = mHelperSurface; > } > #endif why this change?
Attachment #477053 -
Flags: review?(doug.turner) → review-
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #477053 -
Attachment is obsolete: true
Attachment #477517 -
Flags: review?(doug.turner)
Updated•14 years ago
|
Attachment #477517 -
Flags: review?(doug.turner) → review+
Updated•14 years ago
|
tracking-fennec: --- → 2.0+
Assignee | ||
Comment 5•14 years ago
|
||
Here is patch which is just exposing Maemo5 image rendering API for Maemo6 too... because maemo6 also supporting that old API
Attachment #478043 -
Flags: review?(doug.turner)
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 478043 [details] [diff] [review] Enable Image rendering for Maemo6 too I'll move it to another bug
Attachment #478043 -
Flags: review?(doug.turner)
Assignee | ||
Comment 7•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/66336224dfa4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•