598485 - Custom History Settings Will Not Stick

Status: NEW

(Firefox :: Settings UI, defect)

Description

[Michael Coates [:mcoates] (acct no longer active)]

Issue

Custom history settings will not "stick" within Firefox 4 beta 6.  Each time the history handling reverts to "remember history" or "never remember history". When testing I did enter specific exceptions.

Steps to reproduce
1. Go to Preferences->Privacy and select "Use Custom settings for history"
2. Click exceptions and enter some data
3. Close the exceptions window
4. Close the privacy window
5. Go back to preferences and select privacy
6. Observe that the setting is now "Never remember history"
7. Oddly, if you change this to "use custom settings for history" and then click exceptions, the data you entered is still there

Expected result
At step 6 the setting will be "use custom settings for history" and any entered exceptions will be present.

Comment 1

[Michael Coates [:mcoates] (acct no longer active)]

Note: If you uncheck the box for "accept third-party cookies" then the changes actually do stick. So it seems like we just need to make it "stick" when the user only adds exceptions and nothing more.

Comment 2

[(no longer active)]

Adding exceptions doesn't affect the decision of the UI to keep the custom settings view r revert to the previously selected view.  Can you reproduce the same problem by clicking one of the checkboxes instead of steps 2 and 3?

Comment 3

[Michael Coates [:mcoates] (acct no longer active)]

Ehsan, I did that test and it does stick (see comment 1). So is it a valid use case to just add an exception? Could this be a problem for some users as originally described in the issue?

Comment 4

[(no longer active)]

(In reply to comment #3)
> Ehsan, I did that test and it does stick (see comment 1). So is it a valid use
> case to just add an exception? Could this be a problem for some users as
> originally described in the issue?

Yes, I think this is worth fixing.  But unfortunately I don't have enough time to work on it before Firefox 4, so I'm moving it to Preferences to see if anyone else is interested in working on this.