598608 - Add a way to reprocess reports

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[(not currently active) Ted Mielczarek]

If we have a problem with symbols when processing a report (configuration error, or symbols weren't uploaded yet), we wind up with a mostly-useless report and no way to reprocess it. I would like to have a "reprocess this report" button on the report page that would send it back for processing, but keep the same OOID. This way, if we fix the symbols issue, we can easily reprocess reports of interest.

Comment 1

[Laura Thomson :laura]

+1  

This will be useful in more cases than just missing symbols - anything where we fix a processor bug.  Access should be admin (LDAP) limited to avoid DoS.

Need underpinnings in the hbase client, so the first recipient of this bug is...daniel.  Then -> middleware -> webapp.

Comment 2

[Daniel Einspanjer [:dre] [:deinspanjer]]

I don't believe there is anything for me to do here.  The hbaseClient layer already allows for processing a report multiple times.  We store 3 versions of the processed data so if we need to surface the previous ones then we will need to make a call for that, but I suspect you don't want that to be a requirement for the first implementation of the feature, right?

Comment 3

[[:jberkus] Josh Berkus]

Actually, there's a much simpler way to do this.

Either the middleware or the webUI should simply be able to do bulk inserts from a list supplied by the user to the priorityjobs table.  SQL for this is stupid-simple:

INSERT INTO priorityjobs ( UUID ) VALUES ( 'uuid-1-01-6cx' ),
( 'uuid-2-01-6cx'),( 'uuid-3-01-6cx');

To avoid disruption, you might want to cap the size of the list that can be sumbitted at something less than 100 UUIDs.  Also, you might want some way to validate the UUID format ... not sure how well the priorityjobs code handles an invalid UUID.

Comment 4

[Laura Thomson :laura]

This is a middleware + UI change, and nice-to-have.

Comment 5

[(not currently active) Ted Mielczarek]

I'd still find this useful. We hit things like bug 1133372 where we get crashes before we have Microsoft system symbols, and it'd be nice to be able to reprocess the ones we have once we backfill the symbols.

Ideally on the report/index page we'd just have something like "Reprocess crashes with this signature".

Comment 6

[Robert Kaiser]

I wonder if we could in the end get to something where basically an admin can do a super search and then go for "reprocess all crashes in that result".

Comment 7

[Robert Helmer [:rhelmer]]

This was filed before we had an API, we should get it implemented there first (then exposing via UI is easy).

We could support multiple sources for this potentially (list of crash IDs, signature, supersearch result).

Comment 8

[Peter Bengtsson [:peterbe]]

Changing the title again. I have a working patch. You can now reprocess from the Admin pages.

Comment 9

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3265

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/84955b9cdf007a920741c3d8e38c8af0b1ac6466
fixes bug 598608 - Add a way to reprocess reports (#3265)

* fixes bug 598608 - Add a way to reprocess reports
r=adngdb