Closed Bug 598698 Opened 14 years ago Closed 14 years ago

Possible unneeded selectrow_array() call in Bugzilla::Install::make_admin()

Categories

(Bugzilla :: Installation & Upgrading, defect)

Product:
Bugzilla
Component:
Installation & Upgrading
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.2

People

(Reporter: reed, Assigned: reed)

Details

Attachments

(1 file)

patch - v1
921 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review
Attached patch patch - v1 — — Splinter Review 
I just noticed a rogue selectrow_array() call while I was reading Bugzilla::Install::make_admin(). It doesn't seem to be needed, but maybe I'm overlooking something.
Attachment #477569 - Flags: review?(mkanat)
Comment on attachment 477569 [details] [diff] [review]
patch - v1

Wow, yeah, that is weird.
Attachment #477569 - Flags: review?(mkanat) → review+
Flags: approval+
Target Milestone: --- → Bugzilla 4.2
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Install.pm
Committed revision 7489.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: