598778 - Add-on Builder Helper throws exception when unloading addon

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When you press the Test button for an addon being tested in order to stop testing it (Mac OS X, Firefox 4.0b5, Translator add-on on staging server <https://lm-app-flightdeck-stage01.mozillalabs.com/addon/1000190/latest/>), the Add-on Builder Helper throws the following exception, which gets reported in the Error Console:

Error: console is undefined
Source File: resource://jid0-t3eerqgganlch9c50lpqctdunng-jetpack-core-lib/securable-module.js -> resource://jid0-t3eerqgganlch9c50lpqctdunng-addons-builder-helper-lib/addons-builder-helper.js
Line: 39

If you press the button again, however, the addon is unloaded.

Comment 1

[Atul Varma [:atul]]

I fixed this in the latest version of the patch for bug 598720, attachment 477732 [details] [diff] [review].

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Atul: did you apply the latest version of that patch to the helper addon?  I still see the problem in version 0.0.12 as distributed at <https://secure.toolness.com/xpi/addons-builder-helper.html>.

I also see the following (related?) exception in the Error Console when loading the Translator addon <https://builder.mozillalabs.com/addon/edit/1000190/latest/>, which now uses version 0.7 of the core library, on Firefox 4.0b5, which I am under the impression is supposed to be a working combination:

error: An exception occurred.
Traceback (most recent call last):
  File "resource://jid0-f1ue453e6q3ntacqkmrfils4mmo-jetpack-core-lib/plain-text-console.js", line 37, in 
    const {Cc,Ci} = require("chrome");
TypeError: redeclaration of var Cc

Comment 3

[Atul Varma [:atul]]

Myk, could you try out the latest ABH (see bug 610845 comment 1) and see if it resolves this problem? I wasn't able to reproduce it on my end, though I only tested it with .xpi files created by the latest addon sdk.

Comment 4

[Atul Varma [:atul]]

Hmm, I didn't see any funky exceptions like this when using the latest ABH and I don't think daniel or piotr did either, so I'm going to mark this as fixed... please reopen if the problem crops up again.