Closed
Bug 598894
Opened 14 years ago
Closed 14 years ago
Random interned string constants should all move into AvmCore
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
Attachments
(1 file)
29.28 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
There are some on RegExpClass ("index", "input"), many more on XMLClass, and scattered ones throughout the code base. They create arbitrary clutter - if the VM needs them we should instantiate them on startup (because they will be instantiated anyway), and we can optimize bulk instantiation better in one location if that's something we're interested in doing.
Assignee | ||
Comment 1•14 years ago
|
||
Leaves the one identified in bug #598904 alone but moves everything else into AvmCore.
Attachment #477890 -
Flags: review?(edwsmith)
Updated•14 years ago
|
Attachment #477890 -
Flags: review?(edwsmith) → review+
Assignee | ||
Comment 2•14 years ago
|
||
tamarin-redux changeset: 5246:b28f6ad69a91
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•