Closed Bug 598894 Opened 14 years ago Closed 14 years ago

Random interned string constants should all move into AvmCore

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lhansen, Assigned: lhansen)

References

Details

Attachments

(1 file)

There are some on RegExpClass ("index", "input"), many more on XMLClass, and scattered ones throughout the code base.  They create arbitrary clutter - if the VM needs them we should instantiate them on startup (because they will be instantiated anyway), and we can optimize bulk instantiation better in one location if that's something we're interested in doing.
Blocks: 576307
Attached patch Obvious patchSplinter Review
Leaves the one identified in bug #598904 alone but moves everything else into AvmCore.
Attachment #477890 - Flags: review?(edwsmith)
Attachment #477890 - Flags: review?(edwsmith) → review+
tamarin-redux changeset:   5246:b28f6ad69a91
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: