Closed
Bug 598966
Opened 14 years ago
Closed 14 years ago
Idle service should invoke components registered in a idle-daily category
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [Ts])
Attachments
(1 file, 1 obsolete file)
|
2.92 KB,
patch
|
roc
:
review+
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
Various services just need to do their work in idle-daily. To accomplish the task we have to init the component, then register for idle-daily, then wait to be called. It would be better (also from a startup perf point of view) if idle service could init those components by itself before notifying, through a category cache.
|
Assignee | |
Comment 1•14 years ago
|
||
I'll try to bring this out because I want it for bug 541373 and is a possible help for startup time.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [Ts]
|
|
Assignee | |
Comment 2•14 years ago
|
||
The patch is pretty small, maybe too small! Unfortunately I have no idea how I could test this stuff, I can't force a system idle, or at least I think so. Will test manually reducing some timeout.
|
|
Assignee | |
Comment 3•14 years ago
|
||
applies on top of bug 602085, thus it's even smaller than 1.0! tested manually with my patch in bug 570387
Attachment #481063 -
Attachment is obsolete: true
Attachment #481493 -
Flags: review?(sdwilsh)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 481493 [details] [diff] [review] patch v1.1 moving review to roc, since Shawn will be away for some days and is unlikely to find time soon
Attachment #481493 -
Flags: review?(sdwilsh) → review?(roc)
Attachment #481493 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 481493 [details] [diff] [review] patch v1.1 Thanks! This needs approval, it's nice to have to avoid useless work at startup
Attachment #481493 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #481493 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d001a53858f0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•