599134 - Add Performance section to FAQ page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

We need a place to link "Learn more..." links to about the add-on slowdown (mockup: http://people.mozilla.com/~chowse/drop/amo/performance/v2/02_detail.png).

Comment 1

[Wil Clouser [:clouserw]]

Not sure if this should be fligtar or jorge.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Brief explanation about add-on slowdown

I tried to keep it brief and not too technical.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

I assume this won't be landing soon. Moving it to Q4.

Comment 4

[Justin Scott [:fligtar]]

Comment on attachment 481003 [details] [diff] [review]
Patch V1. Brief explanation about add-on slowdown

Looks good, though I will mourn the loss of my trailing whitespace.

Comment 5

[Jeff Balogh (:jbalogh)]

Didn't you rewrite the faq in zamboni, fligtar?

Comment 6

[Justin Scott [:fligtar]]

Yes I did!

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

OK, then this is it:
http://github.com/jvillalobos/zamboni/commit/16660d0f1969d3c506125fa81fd6e5f727dc294f

Which one is being served now? It looks like bug 491908 isn't fixed in the zamboni version.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

That should be http://github.com/jvillalobos/zamboni/commit/d4b392ff1015e1c481dfe423d5a30fdd36523c96, on a separate branch.

I guess this will have to wait until the testing infrastructure is ready.

Comment 9

[Wil Clouser [:clouserw]]

Why is this blocked on anything?

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Well, it doesn't make sense to push it unless the performance tools are there as well. But I guess it doesn't hurt to push it before then.

Comment 11

[Wil Clouser [:clouserw]]

(In reply to comment #10)
> Well, it doesn't make sense to push it unless the performance tools are there
> as well. But I guess it doesn't hurt to push it before then.

Great, let's land it then.  I'd rather have less to think about when we push the actual numbers.  Thanks.

Comment 12

[Jeff Balogh (:jbalogh)]

Thanks! https://github.com/jbalogh/zamboni/commit/fc3cd86

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/en-US/firefox/faq#slow-addons.