Closed Bug 599552 Opened 14 years ago Closed 14 years ago

CGI.pm compile options are different under mod_perl than normal

Categories

(Bugzilla :: Bugzilla-General, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file)

When loading up CGI.pm in mod_perl.pl, the compile-time options are different than the options we normally get when loading up Bugzilla::CGI. This is why mod_perl installations start to generate URLs separated by semicolons instead of ampersands.
Version: 3.6 → 3.0
Attached patch v1Splinter Review
This also does a bit of general cleanup of mod_perl.pl:

* Template.pm itself calls Template::Config->preload, under mod_perl, so we don't have to.
* We didn't need to be loading a lot of those modules--they were being loaded by "use Bugzilla;" anyhow.
* It's better to load Bugzilla::BugMail than Bugzilla::Mailer, since BugMail otherwise doesn't get loaded, and BugMail will load Mailer.
Assignee: general → mkanat
Status: NEW → ASSIGNED
Attachment #478476 - Flags: review?(glob)
Hey hey. Any chance of a review on this one? It's pretty simple.
Comment on attachment 478476 [details] [diff] [review]
v1

r=glob
Attachment #478476 - Flags: review?(glob) → review+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified mod_perl.pl
Committed revision 7605.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: