Closed Bug 599921 Opened 14 years ago Closed 14 years ago

Uninstalling an extension installed with a file pointer will wipe out the directory the files are in rather than just the file pointer

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla2.0b7
Tracking Flags:
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: dataloss, regression)

Attachments

(1 file)

patch rev 1
10.28 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review 
DirectoryInstallLocation.uninstallAddon should be deleting the dir/file/xpi in the install location that represents hte extension, instead it is deleting the resolved path of the extension. Regression from bug 533038
Severity: normal → critical
Keywords: dataloss
blocking2.0: --- → beta7+
Assignee: nobody → dtownsend
Whiteboard: [needs patch]
Attached patch patch rev 1 — — Splinter Review 
Straightforward patch, we should ignore the file from IDToFileMap and instead just look at the file/directory/xpi in the install location's directory and remove that.

Added a useful set of tests to verify file pointer operations.
Attachment #478845 - Flags: review?(robert.bugzilla)
Status: NEW → ASSIGNED
Whiteboard: [needs patch] → [has patch][needs review rs]
Attachment #478845 - Flags: review?(robert.bugzilla) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/0471d08c1958
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][needs review rs]
Target Milestone: --- → mozilla2.0b7
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20101006 Firefox/4.0b7pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: