599989 - Fail gracefully when a duplicate title or slug is submitted

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Erik Rose [:erik][:erikrose]]

Trying to make a new document having the same title-locale or slug-locale pair as an existing one throws an IntegrityError. Do something nicer. I've introduced SlugCollision and TitleCollision in the redirect branch and will be raising them at appropriate times; we just have to catch them in the view.

Comment 1

[Erik Rose [:erik][:erikrose]]

We now have a wiki.views.json_view view that we could use to do real-time validation (thought we should still tolerate collisions that happen server-side). http://github.com/jsocol/kitsune/commit/f74eeabcb03038ee8ee737b1a171ba9bfade6f86

Comment 2

[Erik Rose [:erik][:erikrose]]

According to http://docs.djangoproject.com/en/dev/ref/models/instances/#validating-objects, the ModelForm validation should check the unique_together constraints. Why doesn't it?

Comment 3

[Paul Craciunoiu [:paulc]]

Did you try updating your django version?

Comment 4

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> According to
> http://docs.djangoproject.com/en/dev/ref/models/instances/#validating-objects,
> the ModelForm validation should check the unique_together constraints. Why
> doesn't it?

It totally should. Are we overriding a method without calling super()?

Comment 5

[Erik Rose [:erik][:erikrose]]

Maybe clean()?

Comment 6

[Erik Rose [:erik][:erikrose]]

The example in the docs doesn't call super(), but it wouldn't be the first time the docs were wrong.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Landed:
https://github.com/jsocol/kitsune/commit/953efe2d4b61082979154d7222ee997d80dac9b4

There is a separate issue still, where title and slug uniqueness with locale is case-insensitive, but the check for creating redirects automatically is case-sensitive. I'll file that in a separate bug.

Comment 8

[Rebecca Billings [:rbillings]]

Verified duplicate article names and slugs give error message

Comment 9

[Rebecca Billings [:rbillings]]

Verified duplicate article names and slugs give error message