600151 - Remove the :-moz-submit-invalid default style

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Mounir Lamouri (:mounir)]

Currently :-moz-submit-invalid default style is a box shadow. We wont to get ride of that and have no default style. However, authors will still be able to use the pseudo-class.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Why? When was this decided?

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> Why? When was this decided?

limi, the UX person working with us on web forms think that the red glow is much more disturbing than helping. So we are going to remove that (probably for beta 8).
Any feedback are welcome.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Trivial patch.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 479719 [details] [diff] [review]
Patch v1

r=dbaron

Comment 5

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/20304cf71487

Comment 6

[Nochum Sossonko [:Natch]]

So the box-shadow for the actual invalid parts of the form remains, as well as the tooltip when the form is submitted with invalid inputs. Works nicely, IMHO. Are there any docs on a) this pseudo-class and b) how to override the default behavior of invalid forms in author code?

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to comment #6)
> So the box-shadow for the actual invalid parts of the form remains, as well as
> the tooltip when the form is submitted with invalid inputs. Works nicely, IMHO.
> Are there any docs on a) this pseudo-class and b) how to override the default
> behavior of invalid forms in author code?

The only thing that disappear is the box-shadow on the submit buttons when the form is invalid. Everything else remains the same.
a) https://developer.mozilla.org/en/CSS/:-moz-submit-invalid
b) https://developer.mozilla.org/en/CSS/%3ainvalid ("See also" section might have interesting links)

Comment 8

[Mounir Lamouri (:mounir)]

Actually, we need some dev-doc here because we no longer have a default style.

Comment 9

[Nochum Sossonko [:Natch]]

(In reply to comment #7)
> The only thing that disappear is the box-shadow on the submit buttons when the
> form is invalid. Everything else remains the same.
> a) https://developer.mozilla.org/en/CSS/:-moz-submit-invalid
> b) https://developer.mozilla.org/en/CSS/%3ainvalid ("See also" section might
> have interesting links)

So the actual error message pop-up is not removable? I couldn't find any documentation to implement custom error handling (although there is the option of changing the error string).

Comment 10

[Eric Shepherd [:sheppy]]

Updated the docs to say that this doesn't get styled by default.