Closed Bug 600455 Opened 14 years ago Closed 14 years ago

Media tests' indexed ogg file has invalid index

Categories

(Core :: Audio/Video, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

It turns out that the media mochitests' indexed ogg file has an invalid index. This was caused by a bug in OggIndex's decoder. I'd previously found the bug in Firefox's decoder, which is very similar to OggIndex's, but I must have forgotten to make the same fix to OggIndex.

Firefox's index-decoding code would detect that the index was corrupt, and discard the index, so we weren't actually testing the index decoding. I've fixed the file's index and pushed it to TryServer, and our tests still pass, while exercising the index decoding.
Blocks: 600724
http://hg.mozilla.org/mozilla-central/rev/f6dc94a7b560
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: