Closed
Bug 600812
Opened 14 years ago
Closed 13 years ago
Dragging tab between groups doesn't work
Categories
(Firefox Graveyard :: Panorama, defect, P2)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 4.0b11
People
(Reporter: dietrich, Assigned: ttaubert)
References
Details
(Whiteboard: [ux][polish])
Attachments
(1 file, 5 obsolete files)
4.99 KB,
patch
|
Details | Diff | Splinter Review |
sometimes i'll drag a tab from group A to group B. expected: the tabs in group A rearrange to compensate for the now-missing tab. the tabs in group B rearrange to compensate for the newly-arrived tab. actual: nothing moves in group A, and there's a hole where the tab used to be. nothing moves in group B, and the tab stays wherever i dropped it. error in the console when this happens: GroupItem.add error; tabview assert: shouldn't already be in another groupItem([object MouseEvent])@chrome://browser/content/tabview.js:3351 ([object MouseEvent])@chrome://browser/content/tabview.js:1640 ([object MouseEvent])@chrome://browser/content/tabview.js:675 @:0
Comment 1•14 years ago
|
||
If this is the same bug I'm experiencing, it appears to only happen when Panorama is busy loading thumbnail previews. Once all the previews are loaded, there doesn't appear to be a problem. Though I changed the bug summary, I hesitate to add the part about previews until it is confirmed that these are indeed the same bug. Dietrich, can you confirm that it is only a problem while tab previews are loading?
OS: Linux → All
Hardware: x86 → All
Summary: sometimes dragging between groups results in a broken state → Dragging tab between groups doesn't work
Assignee | ||
Comment 4•14 years ago
|
||
I experience this bug quite often. This happens even when previews are not loading - on average in 1 of 10 tries. The trick is to quickly drag a tab and drop it so that almost no mouseevents are fired. So this might as well happen even more when firefox or the whole computer is under load.
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Comment 6•14 years ago
|
||
Comment on attachment 504196 [details] [diff] [review] patch v1 >+function showTabView(callback) { >+function hideTabView(callback) { Please add an optional win argument, probably after callback, so that we can specify different windows as well. See some of the other head.js functions for examples.
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #6) > Please add an optional win argument, probably after callback, so that we can > specify different windows as well. See some of the other head.js functions for > examples. Good catch! Added.
Attachment #504196 -
Attachment is obsolete: true
Attachment #504210 -
Flags: review?(ian)
Attachment #504196 -
Flags: review?(ian)
Comment 8•14 years ago
|
||
Comment on attachment 504210 [details] [diff] [review] patch v1b (small fixes in head.js) >+ if (TabView.isVisible()) { >+ TabView.show(); >+ if (!TabView.isVisible()) { >+ TabView.hide(); These need to be win.TabView, else they'll just be accessing the main window's TabView.
Assignee | ||
Comment 9•14 years ago
|
||
Attachment #504210 -
Attachment is obsolete: true
Attachment #504254 -
Flags: review?(ian)
Attachment #504210 -
Flags: review?(ian)
Assignee | ||
Comment 10•14 years ago
|
||
Attachment #504254 -
Attachment is obsolete: true
Attachment #504307 -
Flags: review?(ian)
Attachment #504254 -
Flags: review?(ian)
Assignee | ||
Comment 11•14 years ago
|
||
Passed try.
Comment 12•14 years ago
|
||
Comment on attachment 504307 [details] [diff] [review] patch v1d (small fixes in head.js) Looking good. >+ is(targetGroup.getChildren().length, 2, 'target group has two tabs'); Go ahead and also check that sourceGroup has been closed. R+ with that
Attachment #504307 -
Flags: review?(ian) → review+
Assignee | ||
Comment 13•14 years ago
|
||
Attachment #504307 -
Attachment is obsolete: true
Attachment #505251 -
Flags: approval2.0?
Comment 15•13 years ago
|
||
Will this fix bug 608405?
Updated•13 years ago
|
Attachment #505251 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 16•13 years ago
|
||
Attachment #505251 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 19•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/979d2ebe8b7e
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 20•13 years ago
|
||
(In reply to comment #19) > http://hg.mozilla.org/mozilla-central/rev/979d2ebe8b7e Don't think this will make it into beta 10.
Updated•13 years ago
|
Target Milestone: Firefox 4.0b10 → ---
Updated•13 years ago
|
Target Milestone: --- → Firefox 4.0b11
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•