601084 - WebGL shader crash due to endless recursion [@glrCompCreateStream]

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Same comments as in bug 601086 :-)

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Ah no... your call stack here is weirder. Will try to reproduce with MOZ_GL_DEBUG=1 with the patch from bug 597881.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Sorry, I can't reproduce here, with ANGLE enabled, with or without GL debug mode.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

(on windows 7)

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

We've had a big ANGLE upgrade recently. Can you please retry, and close this bug if the crash is gone?

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Also, if the bug is still present, please rerun firefox, go to about:crashes, and give us the relevant link.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Test case doesn't crash anymore here, while it used to.
Also, this is possibly the same as bug 601086 which got fixed as Angle bug http://code.google.com/p/angleproject/issues/detail?id=50

So, I propose RESOLVED WORKSFORME.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Sorry, rereading above commens --- I never could reproduce. Still propose WORKSFORME.

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

No crashes at all with such a signature in the past 2 weeks:

 http://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&platform=windows&platform=mac&platform=linux&platform=solaris&branch=2.0&range_value=2&range_unit=weeks&date=12%2F13%2F2010+14%3A24%3A46&query_search=signature&query_type=contains&query=glrCompCreateStream&build_id=&process_type=any&hang_type=any&do_query=1

Comment 11

[Christoph Diehl [:posidron]]

Attachment: testcase

(0) : fatal error C9999: Multiple main instructions, cannot define main function
Cg compiler terminated due to fatal errornsStringStats

Comment 12

[Benoit Jacob [:bjacob] (mostly away)]

Christoph: thanks for the testcase. Can you please provide a callstack? Would help to figure if there's a security risk.

Comment 13

[Christoph Diehl [:posidron]]

Fixed.