Closed
Bug 601236
Opened 14 years ago
Closed 14 years ago
"ASSERTION: This is unsafe! Fix the caller!" tweaking video.src through attribute nodes
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: smaug)
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
336 bytes,
text/html
|
Details | |
3.71 KB,
text/plain
|
Details | |
2.27 KB,
patch
|
sicking
:
review+
sicking
:
approval2.0+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: This is unsafe! Fix the caller!: 'Error', file content/events/src/nsEventDispatcher.cpp, line 514
Reporter | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Group: core-security
Comment 3•14 years ago
|
||
so, what should we do about this assertion?
Reporter | ||
Comment 4•14 years ago
|
||
Even if this bug isn't a security hole, I'd like it fixed quickly so I can check for other instances of this assertion that might be.
blocking2.0: --- → ?
Assignee | ||
Comment 5•14 years ago
|
||
Jonas, can you think of any reason why this wouldn't be ok in this case.
Attachment #481042 -
Flags: review?(jonas)
Assignee | ||
Comment 6•14 years ago
|
||
So to clarify the patch, it just makes mozAutoDocUpdate to go out of scope before SetValue() So, a { } block was added.
Comment on attachment 481042 [details] [diff] [review] patch Mutation events and attribute nodes together. Can we add document.domain to the mix to get a trifecta of horror :(
Attachment #481042 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #481042 -
Flags: approval2.0?
Attachment #481042 -
Flags: approval2.0? → approval2.0+
Updated•14 years ago
|
Summary: "ASSERTION: This is unsafe! Fix the caller!" twaking video.src through attribute nodes → "ASSERTION: This is unsafe! Fix the caller!" tweaking video.src through attribute nodes
Assignee | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a6c31e83c5dd
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → Olli.Pettay
Assignee | ||
Comment 9•14 years ago
|
||
This was fixed long ago. No need for blocking2.0?
blocking2.0: ? → ---
Updated•9 years ago
|
Group: core-security
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•