Closed
Bug 601273
Opened 14 years ago
Closed 14 years ago
warning C4700: uninitialized local variable 'hr' used in ThebesLayerD3D10.cpp
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: RyanVM, Assigned: bas.schouten)
References
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
mozilla-central\gfx\layers\d3d10\thebeslayerd3d10.cpp(137) : warning C4700: uninitialized local variable 'hr' used
74 HRESULT hr;
....
137 if (SUCCEEDED(hr)) {
138 retainedRegion.Or(retainedRegion, *r);
139 }
|
Reporter | |
Comment 1•14 years ago
|
||
Bas, what should this be initialized to? Should it follow the same pattern as ThebesLayerD3D9.cpp Line #154?
|
Assignee | |
Comment 3•14 years ago
|
||
This is actually a silly bug! It could cause excessive redrawing in some cases. This patch will fix it. Thanks for bringing this to my attention!
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
Attachment #493459 -
Flags: review?(jmuizelaar)
|
||
Updated•14 years ago
|
Attachment #493459 -
Flags: review?(jmuizelaar) → review+
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ba2e3cdbaaf3
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•