601436 - mtable 'align' attribute: negative rownumbers are wrongly interpreted

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[distler]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100926 Firefox/ SeaMonkey/2.1b1pre
Build Identifier: 

According to MathML Spec, the mtable 'align' attribute can accept a positive or negative integer, indicating the row of the table, to which the alignment should be applied. 1,2,... indicate the first, second, ... row. -1, -2, ... indicate the last, next-to-last, ... row.

Gecko recognizes positive values, but not negative ones.

See the testcase. 

Reproducible: Always

Comment 1

[distler]

Attachment: testcase

Comment 2

[distler]

Attachment: incorrect rendering

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Patch

Actually, negative values are taken into account but wrongly interpreted: -1 is considered the penultimate row, -2 the antepenultimate row etc

Comment 4

[Justin Wood (:Callek)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1cfc6b117e15

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/1cfc6b117e15

Comment 6

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en/Firefox_8_for_developers#MathML
https://developer.mozilla.org/en/MathML/Element/mtable#attr-align

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to Florian Scholz [:fs] from comment #6)
> https://developer.mozilla.org/en/Firefox_8_for_developers#MathML
> https://developer.mozilla.org/en/MathML/Element/mtable#attr-align

Ah.  I was originally going to comment here that dev-doc-needed did not seem to apply to fixing bugs, but I see what was really being asked for was updating developers section of release notes to indicate the bug was fixed.  Perhaps we need a different keyword like dev-relnote-needed to make this more clear.

Comment 8

[Bill Gianopoulos [:WG9s]]

Or perhaps it really should have just had the relnote keyword instead of devdoscs-needed.  Devdocs-needed would seem to imply that the developers wiki needs to be updated.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

That's exactly what it means. relnotes are user-facing; dev-doc is developer-facing.

Comment 10

[distler]

Attachment: Incorrect rendering in latest Firefox

Appears to be broken again.

Comment 11

[Frédéric Wang (:fredw)]

(In reply to distler from comment #10)
> Created attachment 8819379 [details]
> Incorrect rendering in latest Firefox
> 
> Appears to be broken again.

Can you please open a new bug?
It would also help to find a regression window: https://mozilla.github.io/mozregression/quickstart.html