Closed
Bug 601958
Opened 14 years ago
Closed 13 years ago
TabView should directly call show and hide routines in the frame
Categories
(Firefox Graveyard :: Panorama, defect, P3)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 6
People
(Reporter: iangilman, Assigned: raymondlee)
Details
(Whiteboard: [API][cleanup])
Attachments
(1 file, 1 obsolete file)
|
2.46 KB,
patch
|
Details | Diff | Splinter Review |
Right now TabView fires "tabviewshow" and "tabviewhide" events to tell the Panorama UI frame to show/hide itself. It should just call into the frame directly, as these events confuse people looking at our API (who really want "tabviewshown" and "tabviewhidden").
|
||
Comment 1•14 years ago
|
||
Seems like something we should fix before extension authors dig in.
Blocks: 585689
Target Milestone: --- → Firefox 4.0
|
||
Comment 2•13 years ago
|
||
Unfortunately, we should punt on this.
|
Assignee | |
Comment 3•13 years ago
|
||
Trivial patch.
|
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 519352 [details] [diff] [review] v1 Thank you for taking care of this!
Attachment #519352 -
Flags: review?(ian) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Passed Try http://tbpl.mozilla.org/?tree=MozillaTry&rev=090f0ac0a3b1
Attachment #519352 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/projects/cedar/rev/a5fce49c7f36
Keywords: checkin-needed
Whiteboard: [API][cleanup] → [API][cleanup][fixed-in-cedar]
Target Milestone: Future → Firefox 6
|
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a5fce49c7f36
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [API][cleanup][fixed-in-cedar] → [API][cleanup]
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•