Closed Bug 602245 Opened 14 years ago Closed 13 years ago

PGO builds fail with --enable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla6

People

(Reporter: chrisccoulson, Assigned: glandium)

References

Details

Attachments

(2 files, 1 obsolete file)

Build failure
6.51 KB, text/plain
Details
Don't build SIMPLE_PROGRAMS during MOZ_PROFILE_GENERATE pass
6.80 KB, patch
ted
: review+
Details | Diff | Splinter Review
Attached file Build failure — 
I tried doing a profiledbuild with latest mozilla-central. I get a build failure when trying to link nsIFileEnumerator (I've attached the error).

The issue seems to be that the objects in libxpcomglue_s are compiled with -fprofile-generate, but the linking is done without (as a side-effect of bug 542504).

The GCC manual states "You must use ‘-fprofile-generate’ both when compiling and when linking your program."
Blocks: 542504
Attachment #481263 - Attachment mime type: application/octet-stream → text/plain
Urgh, and, of course - I meant to say "--enable-tests" ;)
I guess we should fix it the way I said in bug 542504 comment 3 instead. :-/
Summary: PGO builds fail with --disable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate → PGO builds fail with --enable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate
Assignee: nobody → mh+mozilla
Depends on: 643817

        Attachment #521477 -
        Flags: review?(ted.mielczarek)

    
    

    
  


  
The previous iteration led to a failure to build on windows due to xpcom/tests/windows/Makefile.in including config.mk before setting CPP_UNIT_TESTS.

        Attachment #521477 -
        Attachment is obsolete: true

        Attachment #521543 -
        Flags: review?(ted.mielczarek)

        Attachment #521477 -
        Flags: review?(ted.mielczarek)

        Attachment #521543 -
        Flags: review?(ted.mielczarek) → review+

    
  
Blocks: gcc4.5

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/1203611ef3dc
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: