Closed Bug 602386 Opened 14 years ago Closed 14 years ago

nanojit: make Register a non-numeric type on ARM

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Platform:
ARM
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: jbramley)

References

Details

Attachments

(1 obsolete file) 

Bug 599251 introduced the non-numeric Register type.  This back-end doesn't use it yet.  It should.  See the i386/X64 back-ends for examples.

This'll be easier once the codegen macros have been converted to functions (bug 592223).
Attached patch fixup winmo (obsolete) — — Splinter Review 
winmo is puking on R0,D7 usage in First/LastRegNum.

I'm not a big fan of keeping winmo going but if this is all it takes...
Attachment #485936 - Flags: review?(Jacob.Bramley)
Comment on attachment 485936 [details] [diff] [review]
fixup winmo

It looks sensible, but does it belong in this bug?
Attachment #485936 - Flags: review?(Jacob.Bramley) → review+
OS: Mac OS X → All
Hardware: x86 → ARM
Comment on attachment 485936 [details] [diff] [review]
fixup winmo

As the change to Register caused this issue I piggybacked this fix here.  But yes, I suppose a new bug could have been opened for it.

Anyway it has landed and will mark the patch as obsolete.

http://hg.mozilla.org/projects/nanojit-central/rev/ec207b83f9d8
Attachment #485936 - Attachment is obsolete: true
http://hg.mozilla.org/tracemonkey/rev/60c2099aca88
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
http://hg.mozilla.org/tamarin-redux/rev/b986959fbce5

clearing scoreboard since original issue still needs addressing.
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/60c2099aca88
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: