Closed Bug 602389 Opened 14 years ago Closed 13 years ago

nanojit: make Register a non-numeric type on MIPS

Categories

(Core Graveyard :: Nanojit, defect)

Product:
Core Graveyard
Component:
Nanojit
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
flash10.2

People

(Reporter: n.nethercote, Assigned: chris)

References

Details

(Whiteboard: [fixed-in-nanojit][fixed-in-tamarin][inbound])

Attachments

(1 file)

Support non-integer Register type
31.46 KB, patch
n.nethercote
: review+
Details | Diff | Splinter Review 
Bug 599251 introduced the non-numeric Register type.  This back-end doesn't use it yet.  It should.  See the i386/X64 back-ends for examples.
Target Milestone: --- → flash10.2
Tested in nanojit and tamarin-redux
Attachment #527910 - Flags: review?(nnethercote)
Comment on attachment 527910 [details] [diff] [review]
Support non-integer Register type

Review of attachment 527910 [details] [diff] [review]:

r=me
Attachment #527910 - Flags: review?(nnethercote) → review+
Can this change be pushed now?
Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to the whiteboard is the standard way to indicate that.)
(In reply to comment #4)
> Sure.  Do you need someone to do it for you?  (Adding [checkin-needed] to
> the whiteboard is the standard way to indicate that.)

Thanks. I didn't know that so thanks for the pointer :)
Whiteboard: [checkin-needed]
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Is this supposed to land on mozilla-central? If so, the paths in the patch are bogus.
No, it has to land on nanojit-central.  I'll do it.
Keywords: checkin-needed
changeset: 6522:d64e8c9b0731
user:      Chris Dearman <chris@mips.com>
summary:   Comment Bug 602389 - nanojit: make Register a non-numeric type on MIPS.  r=nnethercote.

http://hg.mozilla.org/tamarin-redux/rev/d64e8c9b0731
http://hg.mozilla.org/mozilla-central/rev/806abed2a8f7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
http://hg.mozilla.org/integration/mozilla-inbound/rev/806abed2a8f7
Whiteboard: [fixed-in-nanojit] → [fixed-in-nanojit][fixed-in-tamarin][inbound]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: