Closed
Bug 602568
Opened 14 years ago
Closed 14 years ago
[Mac default] MailNews (tab)scrollbox arrows/buttons needs love
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b2
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(2 files)
7.01 KB,
patch
|
mnyromyr
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
22.43 KB,
image/png
|
Details |
The current ones looks quite ugly: - there's no hover/hover:active state (which would be nice in this case since it'll match the tabs) - there's no border separating the button from the tab - the disabled one is smaller than the normal one
Assignee | ||
Comment 1•14 years ago
|
||
I think this looks much better. The arrows are taken from mail/, they took it from Firefox (but Firefox doesn't use them anymore). Originally, it was 2 sets of 4 images, but I don't think anyone used all 4. I have removed the ones we don't use, so we now only have 2 sets of 2 images. Note btw, that we don't want the directions to be swapped in rtl. TB seems to do that, but I think that's wrong.
Attachment #481589 -
Flags: superreview?(neil)
Attachment #481589 -
Flags: review?(mnyromyr)
Assignee | ||
Updated•14 years ago
|
Target Milestone: --- → seamonkey2.1b2
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•14 years ago
|
||
Here are some screenshots of before/after the patch.
Assignee | ||
Comment 3•14 years ago
|
||
Note btw that I make the whole border transparent in the disabled state. I figured that looked nicer, since I would otherwise have tab and button border next to each other.
Comment 4•14 years ago
|
||
(In reply to comment #1) > The arrows are taken from mail/ Can't we hg copy them in that case?
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #4) > (In reply to comment #1) > > The arrows are taken from mail/ > Can't we hg copy them in that case? Ah, yes, of course - for some reason I didn't thought of that.
Comment 6•14 years ago
|
||
Comment on attachment 481589 [details] [diff] [review] make it look better sr=me if the images are hg copied.
Attachment #481589 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 7•14 years ago
|
||
Neil was ok with not hg copying the images since I've changed them anyway.
Updated•14 years ago
|
Attachment #481589 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Comment 8•14 years ago
|
||
http://hg.mozilla.org/comm-central/rev/b8e41a21ce1f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•