Closed
Bug 602832
Opened 14 years ago
Closed 14 years ago
008filter.t doesn't catch [%~ ~%] correctly
Categories
(Bugzilla :: Testing Suite, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
The current code takes care of [%- -%] and [%+ +%], but not of [%~ ~%], probably because we weren't using ~ in the past. This makes it return some false alarm, such as in bug 581448. I have a patch almost ready.
|
Assignee | |
Comment 1•14 years ago
|
||
I moved the +/-/~ detection where we really parse [% ... %], because directive_ok() is used recursively with the |foo ? bar : baz| syntax, and in that case, it shouldn't treat +/-/~ as special.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 481863 [details] [diff] [review] patch, v1 Cool. :-)
Attachment #481863 -
Flags: review?(mkanat) → review+
|
|
||
Updated•14 years ago
|
Flags: approval4.0+
Flags: approval+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified t/008filter.t Committed revision 7525. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/ modified t/008filter.t Committed revision 7430.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•