603265 - Importing a .cvf with empty lines doesn't work

Status: RESOLVED FIXED

(MailNews Core :: Import, defect)

Description

[Ludovic Hirlimann [:Usul]]

In bug 600798 there are two vcard that are suposed to work with the code added in bug 79709. The first one works, the second one doesn't.

Files can be found at http://hg.mozilla.org/qa/litmus-data/file/947e21f848da/thunderbird/import the emptylines_vcard_addressbook.vcf is the faulty file.

Comment 2

[Leon Sha]

Attachment: patch

Filter out the empty line.

Comment 3

[David :Bienvenu]

Comment on attachment 622993 [details] [diff] [review]
patch

you could instead use do while and pass in aMore directly to ReadLine, so the code would look like this:

do {
  rv = aLineStream->ReadLine(line, aMore);
}
while (line.IsEmpty() && *aMore);
if (!*aMore)
  return rv;

Comment 4

[Leon Sha]

http://hg.mozilla.org/comm-central/rev/d8c08657b365