Closed Bug 603530 Opened 14 years ago Closed 13 years ago

Intermittent cascade of failure starting with browser_tabview_dragdrop.js | Test timed out

Categories

(Firefox Graveyard :: Panorama, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0

People

(Reporter: orangereporter, Assigned: raymondlee)

References

Details

(Keywords: intermittent-failure, Whiteboard: , [qa-])

Attachments

(1 file, 2 obsolete files)

While it's possible that these are all separate things, I find it rather unlikely that in one run, we suddenly hit never-before-seen failures in nine different tests, and much more likely that neither browser_tabview_dragdrop.js nor any of the rest use registerCleanupFunction() to clean up after themselves in case of timeout, nor establish the conditions they need when they start up, so once the first one tripped, they all fell down on top of it.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1286843690.1286844768.9850.gz
Rev3 Fedora 12x64 mozilla-central opt test mochitest-other on 2010/10/11 17:34:50
s: talos-r3-fed64-048

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_dragdrop.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_dragdrop.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_dragdrop.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_exit_button.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_firstrun_pref.js | Main window TabView is hidden
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_firstrun_pref.js | Main window TabView is still hidden
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_group.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_launch.js | Tab View starts hidden
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_launch.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_multiwindow_search.js | Tab View is hidden
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_multiwindow_search.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_multiwindow_search.js | Found a browser window after previous test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_multiwindow_search.js | Found a browser window after previous test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Tab View is hidden
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Found a tab after previous test timed out: http://mochi.test:8888/
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_search.js | Found a tab after previous test timed out: about:blank
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_snapping.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/tabview/browser_tabview_undo_group.js | Test timed out
Is this still an issue?
Target Milestone: --- → Future
(In reply to comment #2)
> Is this still an issue?

Heh.
Target Milestone: Future → ---
OS: Linux → All
Hardware: x86_64 → All
Ian, have you tried to reproduce this locally?  (By running the suite over and over again on a machine)
Depends on: 585689
Target Milestone: --- → Firefox 4.0
Probably not super high priority, but something we should for hygiene reasons get to before 1.0
Priority: -- → P3
Assignee: nobody → raymond
Blocks: 597043
Seems like this is two bugs: 

* browser_tabview_dragdrop.js is flakey (and has recently become more so?)

* We should use registerCleanupFunction in our tests. 

This bug should concentrate on the former; I've created bug 603820 for the latter.
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
The test stops when simulateDragDrop() is invoked and looked like something goes wrong inside that method.  Simplified the simulateDragDrop() would hopefully fix the problem.
Attachment #483417 - Flags: feedback?(ian)
Comment on attachment 483417 [details] [diff] [review]
v1

>+  let incrementX = offsetX / 2;
>+  let incrementY = offsetY / 2;
> 
>   EventUtils.synthesizeMouse(
>+    element, startX, startY, { type: "mousedown" });
>+  
>+  for (let i = 1; i <= 3; i++) {
>+    EventUtils.synthesizeMouse(
>+      element, (startX + incrementX * i), (startY + incrementY * i), 
>+      { type: "mousemove" });
>+  }
> 
>+  EventUtils.synthesizeMouse(
>+    element, (startX + incrementX * 2), (startY + incrementY * 2), 
>+    { type: "mouseup" });

Looks like the drag overshoots the mark by half but then drops on the mark. Why the overshoot?

Otherwise looking good.
Attachment #483417 - Flags: feedback?(ian) → feedback+
Attached patch v1 (obsolete) — Splinter Review
Fixed the comments Ian mentioned.

f+=ian
Attachment #483417 - Attachment is obsolete: true
Attachment #483696 - Flags: review?(dolske)
Comment on attachment 483696 [details] [diff] [review]
v1

rs=me
Attachment #483696 - Flags: review?(dolske) → review+
r=dolske
Attachment #483696 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/caa59a0d7910
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [orange] → [orange][qa-]
Whiteboard: [orange][qa-] → [orange], [qa-]
Blocks: 653099
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
bugspam
No longer blocks: 653099
bugspam
Blocks: 660175
Adding intermittent test failures to new meta bug.

(bugspam)
Blocks: 665844
I accidently re-opened, though it's actually another failure. Closing again and filed bug 667884.
Status: REOPENED → RESOLVED
Closed: 14 years ago13 years ago
Resolution: --- → FIXED
Whiteboard: [orange], [qa-] → , [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: