603826 - verify signature on Android apks

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Aki Sasaki (not active)]

Currently the only known way to verify an Android apk signature is

a) install a known previous apk, with a signature from the desired key, onto an Android device
b) attempt to install the apk to test onto the same device without uninstalling first.

It would be good to be able to verify the signature without actual installation (or multiple installation, as it were).

Then, automate it.  For release builds, definitely; for nightly builds quite possibly.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Welcome to RelEng, here's your first real bug! :-)

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Note: when this lands, a comment should be made in bug 557260 to remind John Ford that this step will want to be included in his work there.

Comment 3

[Marc Jessome[:mjessome]]

Attachment: Add android signature verification steps.

Adds a bash script which will perform the verification step, as well as 3 .sig files which store the correct signature information for staging, nightly, and release.

Comment 4

[Marc Jessome[:mjessome]]

Attachment: Add android signature verification steps to factory.

This will add the step to the buidbotcustom factory to verify the android signature. Currently hard coded to use the nightly signature.

Comment 5

[Marc Jessome[:mjessome]]

Attachment: Add android signature verification steps to factory, correction.

Add android signature verification steps to buildbotcustom factory.
This patch is to correct the incorrectly attached 531090.

Comment 6

[Marc Jessome[:mjessome]]

Attachment: Add android signature verification tool.

Adds a bash script which will perform the verification step, as well as 3 .sig files which store the correct signature information for staging, nightly, and release.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531118 [details] [diff] [review]
Add android signature verification tool.


>+#Pars arguments

typo nit: should be "Parse" r+ with that change.

Otherwise, looks good.

Comment 8

[Marc Jessome[:mjessome]]

Attachment: Android signature verification tool

Removed unused args variable, fixed "Parse" type.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531115 [details] [diff] [review]
Add android signature verification steps to factory, correction.


>+        workdir='%s/%s/%s' % (self.baseWorkDir, self.branchName, self.objdir)

Not using this, so don't need it

>+                 WithProperties('%(toolsdir)s/release/signing/verify-android-signature.sh --apk=dist/%(completeMarFilename)s --tools-dir=%(toolsdir)s --staging')],

set to --nightly instead of --staging

>+            haltOnFailure=True,
>+        )

for now, let's set this to False so that staging runs don't break on this and also the staging sig file can be removed from the tools patch.

Comment 10

[Marc Jessome[:mjessome]]

Attachment: Verify android signature factory step

Removed unused workingdir variable, haltOnFailure set to False, changed --staging to --nightly.

Comment 11

[Marc Jessome[:mjessome]]

Attachment: Android signature verification tool no staging

Removed staging from the android verification tool

Comment 12

[Marc Jessome[:mjessome]]

Attachment: Verify android signature factory step

Set haltOnFailure back to True.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531180 [details] [diff] [review]
Android signature verification tool no staging

looks great. i'll land this tonight and it will go into production tomorrow morning during the usual Tuesday reconfig.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531181 [details] [diff] [review]
Verify android signature factory step

looks good, i'll land this now and it will be in tomorrow's reconfig.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531180 [details] [diff] [review]
Android signature verification tool no staging

http://hg.mozilla.org/build/tools

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 531181 [details] [diff] [review]
Verify android signature factory step

http://hg.mozilla.org/build/buildbotcustom/rev/0dd339b9f01c

Comment 17

[Aki Sasaki (not active)]

bash: /builds/slave/aurora-mob-andrd-r7-ntly/tools/release/signing/verify-android-signature.sh: Permission denied

Comment 18

[Aki Sasaki (not active)]

http://hg.mozilla.org/build/tools/rev/70bf4e8c77ad

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Today's Android nightly had verify signature step run on it and all is well, half this bug is solved.

Now we just need a builder on the 0.7 release that will wait for the signed android builds to show up in the candidates dir and run the apk verification.


create a scheduler like this http://hg.mozilla.org/build/buildbot-configs/file/22920666a9b3/mozilla2/release_master.py#l38 using FtpPoller (http://mxr.mozilla.org/build/source/buildbotcustom/changes/ftppoller.py) that will keep an eye on a dir like http://stage.mozilla.org/pub/mozilla.org/mobile/candidates/4.0b2-candidates/build1/android-r7/ -- we create the android-r7 dir before doing the signing, once the en-US and multi dirs show up in there the builds are available (1 in each dir) for signature verification. We'll also need a signature verification factory in buildbotcustom/process/factory to run the script you wrote and send it the relevant config settings for the particular release that's being run in order to point to the right ftp dir.

Comment 20

[Marc Jessome[:mjessome]]

Attachment: Add url handling to verify-android-signature tool

Checks for url by "://" sub-string (for file://, http://, https://, ftp://, etc.)

Comment 21

[Marc Jessome[:mjessome]]

Attachment: Add a modified script factory to production-0.7

This adds a modified version of the 0.8 script factory to 0.7; Note that it should not be ported to 0.8.

Comment 22

[Marc Jessome[:mjessome]]

Attachment: Android Verification Scheduler

To schedule android verification on releases.
Note: uses the modified script factory for 0.7 and should not be ported to 0.8, but will be easy to implement on 0.8 when necessary.

Comment 23

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 532000 [details] [diff] [review]
Add url handling to verify-android-signature tool

looks good.

Comment 24

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534023 [details] [diff] [review]
Add a modified script factory to production-0.7


>+class ScriptFactory(BuildFactory):
>+    def __init__(self, scriptRepo, scriptName, cwd=None, interpreter=None,
>+         extra_data=None, extra_args=None,

>+ 
>+         envJava = {}
>+         envJava['PATH'] = '/tools/jdk6/bin:%s' % envJava.get('PATH', '/opt/local/bin:/tools/python/bin:/tools/buildbot/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/home/cltbld/bin')
>+         self.addStep(ShellCommand(name="run_script",
>+             command=[interpreter, WithProperties(scriptName)],
>+             timeout=script_timeout, maxTime=script_maxtime,
>+             workdir=".",
>+             haltOnFailure=True,
>+             env=envJava,
>+             warnOnWarnings=True))

instead of setting envJava in here, pass it into the factory from your release_mobile_master as extra_args['env'] so that the ScriptFactory can use different envs depending on what's passed in, an empty env = {} if not.

Comment 25

[Marc Jessome[:mjessome]]

Attachment: Android Verification Scheduler v2

Schedule android verification on releases.
Note: uses the modified script factory for 0.7 and should not be ported to 0.8, but will be easy to implement on 0.8 when necessary.

v2: moved envJava to builder creation, rather than in ScriptFactory.

Comment 26

[Marc Jessome[:mjessome]]

Attachment: Add a modified script factory to production-0.7 v2

This adds a modified version of the 0.8 script factory to 0.7; Note that it should not be ported to 0.8.

v2: add env variable, removing the envJava setting in ScriptFactory.

Comment 27

[Marc Jessome[:mjessome]]

Comment on attachment 534042 [details] [diff] [review]
Add a modified script factory to production-0.7 v2

>diff --git a/process/factory.py b/process/factory.py
>--- a/process/factory.py
>+++ b/process/factory.py
>@@ -7851,8 +7851,56 @@ class AndroidReleaseBuildFactory(Android
>                                self.objdir),
>          extract_fn = parse_make_upload,
>          haltOnFailure=True,
>          description=['upload'],
>          timeout=60*60 # 60 minutes
>         )
>         if self.createSnippet and uploadSnippet:
>             self._uploadSnippet()
>+
>+class ScriptFactory(BuildFactory):
>+    def __init__(self, scriptRepo, scriptName, cwd=None, interpreter=None,
>+         env=None, extra_data=None, extra_args=None,
>+         script_timeout=1200, script_maxtime=None):
>+
>+         BuildFactory.__init__(self)
>+         self.addStep(SetBuildProperty(
>+             property_name='master',
>+             value=lambda b: b.builder.botmaster.parent.buildbotURL
>+         ))
>+         self.addStep(ShellCommand(
>+             name="clobber_scripts",
>+             command=['rm', '-rf', 'scripts'],
>+             workdir=".",
>+         ))
>+         self.addStep(ShellCommand(
>+             name="clone_scripts",
>+             command=['hg', 'clone', scriptRepo, 'scripts'],
>+             workdir=".",
>+             haltOnFailure=True))
>+         self.addStep(ShellCommand(
>+             name="update_scripts",
>+             command=['hg', 'update', '-C', '-r',
>+                      WithProperties('%(script_repo_revision:-default)s')],
>+             haltOnFailure=True,
>+             workdir='scripts'
>+         ))
>+         self.addStep(SetBuildProperty,
>+              name='set_who',
>+              property_name='who',
>+              value=lambda build:str(build.source.changes[0].who),
>+              haltOnFailure=True
>+         )
>+         self.addStep(SetBuildProperty,
>+              name='set_locale',
>+              property_name='locale',
>+              value=lambda build:str(build.source.changes[0].who.split('/')[-2]),
>+              haltOnFailure=True
>+         )
>+ 
>+         self.addStep(ShellCommand(name="run_script",
>+             command=[interpreter, WithProperties(scriptName)],
>+             timeout=script_timeout, maxTime=script_maxtime,
>+             workdir=".",
>+             haltOnFailure=True,
>+             env=env,
>+             warnOnWarnings=True))

Comment 28

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534042 [details] [diff] [review]
Add a modified script factory to production-0.7 v2

Awesome - great work. I'll land this today.

Comment 29

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 532000 [details] [diff] [review]
Add url handling to verify-android-signature tool

http://hg.mozilla.org/build/tools/rev/47ce531e5de1

Comment 30

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534041 [details] [diff] [review]
Android Verification Scheduler v2

http://hg.mozilla.org/build/buildbot-configs/rev/a8df123e3d15

Comment 31

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534042 [details] [diff] [review]
Add a modified script factory to production-0.7 v2

http://hg.mozilla.org/build/buildbotcustom/rev/1fa009457f51

Comment 32

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534041 [details] [diff] [review]
Android Verification Scheduler v2

Just need this patch but for mozilla2/release_mobile_master.py as the staging one is landed, then this bug can be closed.

Comment 33

[Marc Jessome[:mjessome]]

Attachment: Scheduler for mozilla2

The same scheduler from bug 534041 but for Mozilla2.

Comment 34

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 534107 [details] [diff] [review]
Scheduler for mozilla2

http://hg.mozilla.org/build/buildbot-configs/rev/6fa2a8b0d677

landed on default - these will get picked up in production on the next reconfig, and will get used in the next 0.7 release (Fennec 5.0b3?)