Closed Bug 603933 Opened 14 years ago Closed 9 years ago

outlook 2007 invitation reply wrong sender

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Product:
Calendar
Component:
E-mail based Scheduling (iTIP/iMIP)
Version:
Lightning 3.3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
4.0.0.1

People

(Reporter: s-b-u, Assigned: MakeMyDay)

References

Details

Attachments

(1 file)

RemoveXMSOLKSENDERprop-V1.diff
1.54 KB, patch
Fallen
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 1.0b3pre

Notification mails are not correctly recognised by outlook 2007.
Sender of the invitation is also shown as sender of the notification (mail header).

Reproducible: Always

Steps to Reproduce:
1.send invitation from outlook 2007 to lightning
2.accept and send notification
3.back in outlook, you would see the mail is coming from your own outlook account
Same behavior here with Outlook 2007 on WinXP and lightning on WinXP and Linux.
s-b-u, peter, is this still an issue with Lightning 3.3.x?
Resolving this to incomplete due to missing feedback on the above request. Please feel free to reopen the bug if you still expirience the issue.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → INCOMPLETE
Yes, this is still an issue.

Sorry, I didn't notice your comment.
Peter, thank you for your reply. Can you please provide what's logged to the error console (ctrl+shift+j) when reproducing the issue? Please enable debug logging for this by setting calendar.debug.log and calendar.debug.log.verbose to true using the config editor (menu->options->options->advanced->general). If these params do not already exist, just create them.
Status: RESOLVED → UNCONFIRMED
Resolution: INCOMPLETE → ---
I think this is the important bit, specifically the line X-MS-OLK-SENDER;


mail text:
MIME-version: 1.0
From: peter@foo
To: organizer@foo
Date: Wed, 22 Oct 2014 11:16:47 GMT
Subject: Event Invitation Reply (Tentative): Control
Content-class: urn:content-classes:calendarmessage
Content-type: text/calendar; method=REPLY; charset=UTF-8
Content-transfer-encoding: 8BIT

BEGIN:VCALENDAR
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
VERSION:2.0
METHOD:REPLY
BEGIN:VEVENT
CREATED:20141022T111702Z
LAST-MODIFIED:20141022T111647Z
DTSTAMP:20141022T111647Z
UID:040000008200E00074C5B7101A82E0080000000060458877FAEDCF0100000000000000
 0010000000FD5CEAB111485B4AAF6E654CD8B69580
SUMMARY:Control
PRIORITY:5
ORGANIZER;CN=Fake Organizer:mailto:organizer@foo
ATTENDEE;CN=Jens Peter;PARTSTAT=TENTATIVE:mailto:peter@foo
DTSTART;VALUE=DATE:20150505
DTEND;VALUE=DATE:20150509
CLASS:PUBLIC
DESCRIPTION:Zeit: Dienstag\, 5. Mai 2015 00:00 bis Samstag\, 9. Mai 2015 0
 0:00 (UTC+01:00) Amsterdam\, Berlin\, Bern\, Rom\, Stockholm\, Wien.\nOrt:
  Stuttgart\n\nHinweis: Die oben angegebene Abweichung von GMT berücksicht
 igt keine Anpassungen für Sommerzeit.\n\n*~*~*~*~*~*~*~*~*~*\n\nBitte fü
 r eine eventl. Messebeteiligung den Termin frei halten.\n
LOCATION:Stuttgart
SEQUENCE:0
TRANSP:OPAQUE
X-ALT-DESC;FMTTYPE=text/html:<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//
 EN">\n<HTML>\n<HEAD>\n<META NAME="Generator" CONTENT="MS Exchange Server v
 ersion 08.00.0681.000">\n<TITLE></TITLE>\n</HEAD>\n<BODY>\n<!-- Converted 
 from text/rtf format -->\n\n<P DIR=LTR><SPAN LANG="de"><FONT FACE="Calibri
 ">Zeit: Dienstag\, 5. Mai 2015 00:00 bis Samstag\, 9. Mai 2015 00:00 (UTC+
 01:00) Amsterdam\, Berlin\, Bern\, Rom\, Stockholm\, Wien.</FONT></SPAN></
 P>\n\n<P DIR=LTR><SPAN LANG="de"><FONT FACE="Calibri">Ort: Stuttgart</FONT
 ></SPAN></P>\n\n<P DIR=LTR><SPAN LANG="de"><FONT FACE="Calibri">Hinweis: D
 ie oben angegebene Abweichung von GMT berücksichtigt keine Anpassungen f
 ür Sommerzeit.</FONT></SPAN></P>\n\n<P DIR=LTR><SPAN LANG="de"><FONT FACE
 ="Calibri">*~*~*~*~*~*~*~*~*~*</FONT></SPAN></P>\n\n<P DIR=LTR><SPAN LANG=
 "de"><FONT FACE="Calibri">Bitte für eine eventl. Messebeteiligung den Ter
 min frei halten.</FONT></SPAN></P>\n\n</BODY>\n</HTML>
X-MICROSOFT-CDO-BUSYSTATUS:TENTATIVE
X-MICROSOFT-CDO-IMPORTANCE:1
X-MICROSOFT-CDO-INTENDEDSTATUS:FREE
X-MICROSOFT-DISALLOW-COUNTER:FALSE
X-MS-OLK-ALLOWEXTERNCHECK:TRUE
X-MS-OLK-AUTOSTARTCHECK:FALSE
X-MS-OLK-CONFTYPE:0
X-MS-OLK-SENDER;CN=Fake Organizer:mailto:organizer@foo
END:VEVENT
END:VCALENDAR
Thanks Peter, this maybe a hint. I'll check on this.
Attached patch RemoveXMSOLKSENDERprop-V1.diff — — Splinter Review 
Based on [1], the X-MS-OLK-SENDER property is only intended for cases where the invitation is send by somebody else than the organizer, similar to the SENT-BY param defined in RfC 5545. This prop is only supported by Outolook 2007+ without using Exchange[2].

As we support the "sending on behalf" scenario already by using "Sent-By" in mail header and as organizer/attendees param, I think this is safe to just drop the X-MS-OLK-SENDER on sending out replies.

[1] https://msdn.microsoft.com/en-us/library/ee219350%28v=exchg.80%29.aspx#endNote256
[2] https://msdn.microsoft.com/en-us/library/ee160562%28v=exchg.80%29.aspx#id256
Assignee: nobody → makemyday
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8557592 - Flags: review?(philipp)
Comment on attachment 8557592 [details] [diff] [review]
RemoveXMSOLKSENDERprop-V1.diff

Review of attachment 8557592 [details] [diff] [review]:
-----------------------------------------------------------------

Did you test this with Outlook clients? Code looks fine, but we should make sure it actually fixes the bug and doesn't cause any other issues.
Attachment #8557592 - Flags: review?(philipp) → review+
I haven't - I have no standalone Outlook around. Nevertheless, removing this is safe anyway, because not to roundtrip this property is what is intended if I got the MS reference correctly.

@Peter, s-b-u: Can you please give this patch a try?

1. Reproduce the bug with Lightning 3.3.3.
2. Make a backup of your existing calItipUtils.jsm in folder [Your TB profile folder]->extensions->{e2fda1a4-762b-4020-b5ad-a41df1933103}->modules.
3. Apply the patch attached to this bug on the file [1]
4. Again, reproduce the bug.
5. Please report back whether the sender appears now correctly in Outlook
6. Roll back the patch - at least if it didn't work.

[1] if you're not familiar with patching, just open the file with a text editor, add the lines with a leading '+' to the file - you can find the right place either by the line number by the ccontext lines above and below the new ones in the patch - and remove all the leading '+' subsequently.
Flags: needinfo?(s-b-u)
Flags: needinfo?(peter)
(In reply to MakeMyDay from comment #10)
I can confirm that the patch solves the problem.

I used Lightning 3.3.2 as participant and Outlook 2007 as initiator.

Mademyday, @MakeMyDay!
Flags: needinfo?(peter)
Thanks for testing Peter!

https://hg.mozilla.org/comm-central/rev/f49ca303c8e4
Severity: major → normal
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 9 years ago
Flags: needinfo?(s-b-u)
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → 4.0
Version: unspecified → Lightning 3.3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: