603994 - (fx40-p12n-mr) [mr] Firefox 4.0 productization review for Marathi

Status: RESOLVED FIXED

(Mozilla Localizations :: mr / Marathi, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Marathi and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/mr>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Marathi builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it.  However please note the new update about Bloglines below.

Mozilla has been contacted by the new owners of Bloglines who have said they will keep the service running.  If you have no other options, you can consider leaving it.  However, it is hard to say whether that team who is now in control of Bloglines will change their mind again.  The l10n-drivers feel that it would be best to remove it altogether.

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.

Comment 2

[Axel Hecht [:Pike]]

Sandeep, can you create a patch for l10n-central to actually really remove keyword.URL and not just comment it out in region.properties, and to update the icon in the yahoo-in.xml plugin to be the one we use on 1.9.2?

Thanks.

Comment 3

[sandeep shedmake]

Attachment: patch (as per Comment 2)

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 495491 [details] [diff] [review]
patch (as per Comment 2)

>diff --git a/browser/chrome/browser-region/region.properties b/browser/chrome/browser-region/region.properties
>--- a/browser/chrome/browser-region/region.properties
>+++ b/browser/chrome/browser-region/region.properties
>@@ -15,17 +15,16 @@ browser.search.order.2=Yahoo
> browser.contentHandlers.types.0.title=Bloglines
> browser.contentHandlers.types.0.uri=http://www.bloglines.com/login?r=/sub/%s
> browser.contentHandlers.types.1.title=My Yahoo
> browser.contentHandlers.types.1.uri=http://add.my.yahoo.com/rss?url=%s
> browser.contentHandlers.types.2.title=Google
> browser.contentHandlers.types.2.uri=http://fusion.google.com/add?feedurl=%s
> 
> # Keyword URL (for location bar searches)
>-#keyword.URL=http://www.google.com/search?ie=UTF-8&oe=UTF-8&sourceid=navclient&gfns=1&q=
> 

Remove the comment and one of the empty lines, as well?

r=me with that.

Please land with check-in comment referencing this bug and my review, something like
"bug 495491, update yahoo icon to match 1.9.2, remove keyword.URL, r=[e-mail]"
would work

Comment 5

[sandeep shedmake]

Changes pushed with changeset 31dea881df72

Comment 6

[sandeep shedmake]

(In reply to comment #5)
> Changes pushed with changeset 31dea881df72

removed the empty line after keyword.URL; with changeset 11c4601433b6.

Comment 7

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to
remove it.  Do you want to remove it, there too?  Please provide a patch for that removal on 1.9.2 as well.

Comment 8

[sandeep shedmake]

Attachment: patch to remove Bloglines from 1.9.2, added Bing

Comment 9

[Seth Bindernagel]

Comment on attachment 495820 [details] [diff] [review]
patch to remove Bloglines from 1.9.2, added Bing

We are not adding Bing to Firefox 3.6 (aka 1.9.2 branch), only to Firefox 4.  Please attach a patch that only removes bloglines.  No need to add Bing anywhere here.

Comment 10

[Axel Hecht [:Pike]]

Sandeep, the comment fixup wasn't exactly what I was expecting, do you mind if I just go in and fix and commit that? You'd have to hg pull -u to incorporate that into your working copy then.

Comment 11

[sandeep shedmake]

(In reply to comment #10)
> Sandeep, the comment fixup wasn't exactly what I was expecting, do you mind if
> I just go in and fix and commit that? You'd have to hg pull -u to incorporate
> that into your working copy then.

Yes, i am fine with it. Please, proceed with the fix. 
I would "hg pull -u" to incorporate the fix in working copy.

Comment 12

[Axel Hecht [:Pike]]

Pushed http://hg.mozilla.org/l10n-central/mr/rev/7a2b3f90bf8f

https://l10n-stage-sj.mozilla.org/dashboard/compare?run=108778 looks like you might have forgotton to 

hg add toolkit/chrome/global/aboutStartup.dtd toolkit/chrome/global/aboutStartup.properties
?

Comment 13

[Axel Hecht [:Pike]]

Forget the latter, those just landed, sorry :-)

Comment 14

[sandeep shedmake]

Attachment: patch to remove Bloglines from 1.9.2

Comment 15

[Seth Bindernagel]

Comment on attachment 496098 [details] [diff] [review]
patch to remove Bloglines from 1.9.2

Thank you for this patch.  It looks good to me.  Please check this in on 1.9.2, adding a comment to the check-in that references bug 603994, the Bloglines change, and r=sethb.

Once you have landed that, please test the new build and then sign off.  Don't forget to sign-off using Pike's sign-off app or the change will not get picked up.  

Lastly, once all is finished, feel free to close the bug.

Comment 16

[sandeep shedmake]

(In reply to comment #15)
> Comment on attachment 496098 [details] [diff] [review]
> patch to remove Bloglines from 1.9.2
> 
> Thank you for this patch.  It looks good to me.  Please check this in on 1.9.2,
> adding a comment to the check-in that references bug 603994, the Bloglines
> change, and r=sethb.
> 

http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/mr/pushloghtml?changeset=7a84aa7a7fbf

> Once you have landed that, please test the new build and then sign off.  Don't
> forget to sign-off using Pike's sign-off app or the change will not get picked
> up.  
> 

https://l10n-stage-sj.mozilla.org/shipping/pushes?locale=mr&av=fx3.6

> Lastly, once all is finished, feel free to close the bug.

--
Sandeep

Comment 17

[sandeep shedmake]

From Comment 15 and and Comment 16, I believe I don't have the required permissions to change the status of this bug from NEW to RESOLVED.

Comment 18

[Axel Hecht [:Pike]]

(In reply to comment #17)
> From Comment 15 and and Comment 16, I believe I don't have the required
> permissions to change the status of this bug from NEW to RESOLVED.

I just changed your priviledges to be able to do so.

Please use your new powers with care.

Comment 19

[sandeep shedmake]

From Comment 18,

Thanks Pike. 
Yes, I would wisely use the permissions granted.


Moving the status of this bug from NEW to RESOLVED.