604005 - (fx40-p12n-rm) [rm] Firefox 4.0 productization review for Romansh

Status: RESOLVED FIXED

(Mozilla Localizations :: rm / Romansh, defect)

Description

[Staś Małolepszy :stas]

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Romansh and make any changes that you think will be good for our users.

What is a productization review?
================================

Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/rm>

Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.

Required changes
================

There's two things I would like to draw your attention to (if applicable):

1) if you have a google.xml file in your `searchplugins` directory, please remove it,

2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!

Changes in en-US and en-GB
==========================

Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.

We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Romansh builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.


Implementation
==============

Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.

Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.

If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.

Thanks!

Comment 1

[Seth Bindernagel]

Bloglines still remains in your 1.9.2 repository.  Please prepare a patch to remove it.  However please note the new update about Bloglines below.

Mozilla has been contacted by the new owners of Bloglines who have said they will keep the service running.  If you have no other options, you can consider leaving it.  However, it is hard to say whether that team who is now in control of Bloglines will change their mind again.  The l10n-drivers feel that it would be best to remove it altogether.

Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central.  Thank you.

Comment 2

[Seth Bindernagel]

Ping.

Comment 3

[Gion-Andri Cantieni [:gion-andri]]

Our main problem in Romansh is that the RSS-Feed for the live-bookmark doesn't work anymore. I contacted them different times and they promised to implement a new one, but this isn't done yet. I'll contact them tomorrow once again. 

Removing Bloglines and set Google on the first position is ok for Romansh. But I didn't understand if I have to do it also for 1.9.2 or only for mozilla-central. 

I propose to remove CreativeCommons from the search plugins. I don't know how often Bing is used in Switzerland - I personally don't know anyone who uses it. So I don't think we need to add it. 

Shall I attatch a patch to make the Blogline and Search-plugin changes on mozilla-central?

Comment 4

[Seth Bindernagel]

(In reply to comment #3)
> Our main problem in Romansh is that the RSS-Feed for the live-bookmark doesn't
> work anymore. I contacted them different times and they promised to implement a
> new one, but this isn't done yet. I'll contact them tomorrow once again. 

We should probably file a separate bug for that issue.  Can you file that?

> 
> Removing Bloglines and set Google on the first position is ok for Romansh. But
> I didn't understand if I have to do it also for 1.9.2 or only for
> mozilla-central. 

You should prepare the patch for these two cases.  I can review both patches, one for 1.9.2 and one for l10n-central.

> 
> I propose to remove CreativeCommons from the search plugins. I don't know how
> often Bing is used in Switzerland - I personally don't know anyone who uses it.
> So I don't think we need to add it. 
> 
> Shall I attatch a patch to make the Blogline and Search-plugin changes on
> mozilla-central?

Yes.  

For 1.9.2, attach a patch that removes Bloglines.

For l10n-central, attach a second patch that removes Bloglines, removes Creative Commons from list.txt, and adds Bing to list.txt.  That's all you have to do.

Comment 5

[Gion-Andri Cantieni [:gion-andri]]

Attachment: Remove Bloglines on 1.9.2 for Romansh

Comment 6

[Gion-Andri Cantieni [:gion-andri]]

Attachment: Remove bloglines and change search plugins on l10n-central

Removing bloglines, remove Creative Commons and add Bing to search-plugins on l10n-central for Romansh

Comment 7

[Gion-Andri Cantieni [:gion-andri]]

I added the two patches and opend bug 626194 for the live-bookmark issue.

Comment 8

[Seth Bindernagel]

Comment on attachment 504227 [details] [diff] [review]
Remove Bloglines on 1.9.2 for Romansh

This looks good. Please land this in your 1.9.2 repository.  Add a checkin comment that references bug 604005, this change to remove Bloglines, and r=sethb.

Once you have landed and tested, please sign off.  Don't forget to sign off or the change will not get picked up with the next 3.6 minor update.

Comment 9

[Seth Bindernagel]

Comment on attachment 504228 [details] [diff] [review]
Remove bloglines and change search plugins on l10n-central

You do not need to add Bing to the predefined search order.  But, if you choose, you need to make sure that the numbers that increment each engine are not the same.  You have two options here:

1)  Remove Yahoo so it looks like this:

 browser.search.order.1=Google
-browser.search.order.2=Yahoo
+browser.search.order.2=Bing
 
2)  Make Bing the third option so it would look like this:

 browser.search.order.1=Google
 browser.search.order.2=Yahoo
+browser.search.order.3=Bing
 
Please make that correction and reattach and then I will approve.

Comment 10

[Gion-Andri Cantieni [:gion-andri]]

Attachment: Remove bloglines and change search plugins on l10n-central

Removing bloglines, remove Creative Commons and add Bing to search-plugins on l10n-central for Romansh.

Comment 11

[Gion-Andri Cantieni [:gion-andri]]

Ah, sorry, what a stupid mistake… The new version should be fine.

Comment 12

[Gion-Andri Cantieni [:gion-andri]]

Landed for 1.9.2 in 
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/rm/file/084b5e1c9519

Comment 13

[Seth Bindernagel]

Comment on attachment 504406 [details] [diff] [review]
Remove bloglines and change search plugins on l10n-central

Please land on l10n-central and add a comment to your checkin that references bug 604005, these changes, and r=sethb.

Once you have tested the nightly build, don't forget to sign off.  With sign off, we'll take this change in the next beta.

Lastly, you can close this bug after you're done doing the above.  :)

Comment 14

[Gion-Andri Cantieni [:gion-andri]]

Landed on l10n-central in 
http://hg.mozilla.org/l10n-central/rm/file/0ea5dc1954b5

Comment 15

[Gion-Andri Cantieni [:gion-andri]]

when I'm creating a new profile on the firefox 4 nightly builds, Creative Commons is still a search plugin. Is it not sufficient to make a new profile to test if Creative Commons disappears? 

Removing Bloglines worked on 1.9.2 and l10n-central.

Comment 16

[Axel Hecht [:Pike]]

nope, you'll need to do a clean install. From the build logs, things look fine, it's just that depending on how you got to the build, old search plugins may or may not be removed. See also bug 603298 comment 30.

Comment 17

[Seth Bindernagel]

So, Gion-Andri,  Try doing the clean installation and then test.  Once it is tested and signed off, you can close this bug, resolving as fixed.  OK?

(By clean install, just install the nightly build somewhere other than the directory where you keep your existing Firefox version.  I often just use my Desktop and then delete later when I am done testing.)

Comment 18

[Gion-Andri Cantieni [:gion-andri]]

I did a clean installation and it works also on l10n-central how it should. Thanks for your help.