604175 - ignoring of invalid at-keywords (@-keywords) should stop at end of containing block ({})

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://test.csswg.org/suites/css2.1/20100917/xhtml1/at-rule-013.xht fails because we haven't implemented the new rule in CSS 2.1 regarding ignoring of invalid at-keywords:

# User agents must ignore an invalid at-keyword together with everything
# following it, up to the end of the block that contains the invalid at-keyword,
# or up to and including the next semicolon (;), or up to and including the next
# block ({...}), whichever comes first.

We incorrectly continue past the end of the block that contains the invalid at-keyword.

Comment 1

[Tantek Çelik]

(citation)

The # quoted text above (User agents must ignore...) is from the list item that starts with "At-rules with unknown at-keywords." in section "4.2 Rules for handling parsing errors" in CSS 2.1: http://www.w3.org/Style/css2-updates/css2/syndata.html#parsing-errors

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

oops, forgot to update patch description

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 506828 [details] [diff] [review]
patch

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/projects/birch/rev/b6a3ab183a8f

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/b6a3ab183a8f