604294 - unicode-bidi: bidi-override doesn't work on table cells

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://test.csswg.org/suites/css2.1/20101001/xhtml1/bidi-override-002.xht shows that unicode-bidi: bidi-override doesn't work on table cells.

I think all we need to do to fix this is give the anonymous block that lives inside table cells unicode-bidi: inherit.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Work in progress, although these rules could use a little cleanup:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/07626d34460e/unicode-bidi-inherit

Comment 2

[Boris Zbarsky [:bzbarsky]]

Do we need similar changes to ::-moz-fieldset-content?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also:
http://test.csswg.org/suites/css2.1/20101001/html4/unicode-bidi-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20101001/xhtml1/unicode-bidi-applies-to-007.xht

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

As far as I can tell, adding to :-moz-anonymous-block and :-moz-anonymous-positioned-block shouldn't make any difference since they always contain other blocks, but it seems like a good idea to add it anyway in case we use those pseudos for other things.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 527729 [details] [diff] [review]
patch

r=me

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/b3d5c9a7a5e5