604302 - Windows DLL blocklist support for Windows x64

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Makoto Kato [:m_kato]]

Bug 524904 is for x86 only.  To support blocklist support for x64, we need implement this.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: WIP v0.1

- add detect mov instruction

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix v1

It works on Vista.  After testing on Win7, I send a review

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 496783 [details] [diff] [review]
fix v1

Hmm, looks fine; I didn't look into the instruction decode in detail, though.  Also, I assume that the assumption we're making is that the PULONG argument showed up on 64-bit systems, and that on 32-bit it doesn't matter?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to comment #3)
> Comment on attachment 496783 [details] [diff] [review]
> fix v1
> 
> Hmm, looks fine; I didn't look into the instruction decode in detail, though. 
> Also, I assume that the assumption we're making is that the PULONG argument
> showed up on 64-bit systems, and that on 32-bit it doesn't matter?

When disassembling LdrLoadDll on Win7, 2nd parameter uses as 64-bit (PULONG is 64-bit).  If using ULONG instead, flag comparing may be fail since upper 32bit is garbage.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: fix v2

we should not use RAX becuase RAX is used by syscall, so injecting TrackPopupMenu doesn't work well.

Comment 6

[Makoto Kato [:m_kato]]

http://hg.mozilla.org/mozilla-central/rev/c062731105cf