Closed
Bug 605081
Opened 14 years ago
Closed 14 years ago
Editor refuses to insert a <keygen> element
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: glazou, Assigned: glazou)
Details
Attachments
(1 file)
1.59 KB,
patch
|
ehsan.akhgari
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
It's impossible to insert a <keygen> element in the editor using insertNode() or insertElementAtSelection(). The element is not inserted into the document tree, and there's no transaction recorded. Blocks BlueGriffon.
Assignee | ||
Comment 1•14 years ago
|
||
Updated•14 years ago
|
Attachment #483916 -
Flags: review+
Attachment #483916 -
Flags: approval2.0?
Assignee: nobody → daniel
Attachment #483916 -
Flags: approval2.0? → approval2.0+
BTW it seems like we should have tests to ensure all the elements we want to be able to insert actually can be inserted (via various methods).
Comment 3•14 years ago
|
||
(In reply to comment #2) > BTW it seems like we should have tests to ensure all the elements we want to be > able to insert actually can be inserted (via various methods). Yes, absolutely. This is among many stuff in the editor that I'm planning to write tests for post 2.0.
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/da4897bd001d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #2) > BTW it seems like we should have tests to ensure all the elements we want to be > able to insert actually can be inserted (via various methods). Sure. Even w/o tests, that list is really easy to determine just looking at kElements in nsHTMLEditUtils.cpp and nsHTMLEditUtils::CanContain()
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•